Use dependencies.yaml to generate environment files
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
approved these changes
Dec 5, 2023
cwharris
changed the title
dependencies.yaml to include cuda-pythondependencies.yaml to generate environment files
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-24.03 #416 +/- ##
================================================
+ Coverage 74.00% 74.03% +0.02%
================================================
Files 394 394
Lines 13955 13955
Branches 1054 1053 -1
================================================
+ Hits 10328 10331 +3
+ Misses 3627 3624 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mdemoret-nv
approved these changes
Dec 6, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates MRC to use
dependencies.yamlfor the source of truth for environment files, and adds a pre-commit hook to ensure the environment files get generated before commit. Also adds the pre-commit hook as a check in CI to ensure we catch missed changes.