Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NR zip code display #1147

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix NR zip code display #1147

merged 1 commit into from
Oct 22, 2024

Conversation

mmontesanonyc
Copy link
Contributor

PR checklist:

  • Changes previewed and QC'ed
  • In PR, mention team member for FYI, review, or approval

New content (if applicable):

  • Date updated
  • Tags and keywords updated
  • Feature box updated

New data (if applicable)

  • Added to Recently Updated
  • Added to 311-crosswalk

@mmontesanonyc
Copy link
Contributor Author

@etorem, I just revised a part of the NR output that fixes how the ZIP Codes are displayed here. Previously there was no space after the commas, so the overflow would spill out and it wouldn't wrap to a new line (which you can see on the live site now). I've done a little bit of testing to make sure I haven't introduced anything unexpected, but could you also please click through the NRs on this branch (hotfix-NR-ZIPs) to ensure that this ZIP printing bit is working? Thanks!

image

@etorem
Copy link
Contributor

etorem commented Oct 22, 2024

I clicked through NRs for an entry with a lot of zip codes, and it seems to wrap well. @mmontesanonyc

@mmontesanonyc
Copy link
Contributor Author

Thanks! Always helpful to have an extra set of eyes before a merge.

@mmontesanonyc mmontesanonyc merged commit 836893d into production Oct 22, 2024
@etorem
Copy link
Contributor

etorem commented Oct 22, 2024 via email

@mmontesanonyc mmontesanonyc deleted the hotfix-NR-ZIPs branch October 31, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants