Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ocaml/testsuite/ #2795

Closed
wants to merge 1 commit into from

Conversation

mshinwell
Copy link
Collaborator

Some of this was done pretty hastily but I think it's a good start. We should probably do something like:

  • get the tree in a state where tests can be run
  • run the tests
  • promote everything (there will be many changes caused by double quotes being put around type names etc)
  • fix failures (checking the diff of a particular test if it fails)
  • check the whole diff

@mshinwell
Copy link
Collaborator Author

Update: this now contains all fixes to ocaml/testsuite/ from mshinwell/5.2-runtime-wip-main, where except for a few typing tests everything seems to pass.

@mshinwell
Copy link
Collaborator Author

The build system fix (relating to the lib) library relates to Makefile changes made upstream. Instead of trying to port those I've simply written dune rules.

@mshinwell mshinwell changed the title First batch of testsuite resolution Fixes for ocaml/testsuite/ Aug 19, 2024
@mshinwell
Copy link
Collaborator Author

This will need splitting for review, #2976 contains the first chunk (and indeed the majority).

@mshinwell mshinwell closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant