Apply 'if-then-else=vertical' to ocamlformat #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetiot
added
the
no changelog
Julow
reviewed
Nov 4, 2022
There was a problem hiding this comment.
Let's switch the profile at once. It's possible to ask git blame to ignore some commits (see in odoc), it's easier to keep track if there's fewer of them.
|
Yes but we may have to modify 20 options to get the profile ready, I think it would be nice to benefit from these improvements as soon as we can on our own code. |
|
Alright let's wait to be able to apply the whole profile at once to reduce the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocamlformat will become the first project to adopt the future diff-friendly profile (#2020) before it's made available to other projects. Let's switch one option at a time to reduce the future diff.