Code

Refactor handling of comments#2371

Code

Merged

Julow merged 63 commits intoocaml-ppx:mainocaml-ppx/ocamlformat:mainfrom Julow:cmts-factorJulow/ocamlformat:cmts-factorCopy head branch name to clipboardNov 8, 2023

+1,162-427

Commits

Commits on May 31, 2023

• WIP: Factorize interpretation of comments

  Show description for 7df9213
  Julow

  committed
  7df9213

  Copy full SHA for 7df9213

• Fix lost ending space

  Julow

  committed
  9caf607

  Copy full SHA for 9caf607

• Promote

  Julow

  committed
  207f471

  Copy full SHA for 207f471

• WIP: Rewrite parsing of normal and asterisk prefixed comments

  Show description for 86ff2e4
  Julow

  committed
  86ff2e4

  Copy full SHA for 86ff2e4

• Test 'error4' requires one more iteration

  Julow

  committed
  f5cce1a

  Copy full SHA for f5cce1a

• Fix added newline in cinaps comments

  Julow

  committed
  032f6c3

  Copy full SHA for 032f6c3

• Strip trailing spaces of cinaps comments

  Julow

  committed
  124a89b

  Copy full SHA for 124a89b

• Promote

  Julow

  committed
  2d0930d

  Copy full SHA for 2d0930d

• Strip heading/trailing empty lines

  Show description for b207454
  Julow

  committed
  b207454

  Copy full SHA for b207454

• Small cleanup in docstring fmt function

  Julow

  committed
  e8875b5

  Copy full SHA for e8875b5

• Fix incorrect unindenting of cinaps comments

  Julow

  committed
  c42280a

  Copy full SHA for c42280a

• Normalize comments in code in comments

  Julow

  committed
  4e4ef13

  Copy full SHA for 4e4ef13

• Revert "Normalize comments in code in comments"

  Show description for 7e9e6ab
  Julow

  committed
  7e9e6ab

  Copy full SHA for 7e9e6ab

Commits on Jun 1, 2023

• Fix unindenting when first line is empty

  Julow

  committed
  6061527

  Copy full SHA for 6061527

• Don't unindent doc comments

  Show description for 520a35c
  Julow

  committed
  520a35c

  Copy full SHA for 520a35c

• Revert "Test 'error4' requires one more iteration"

  Show description for 2095965
  Julow

  committed
  2095965

  Copy full SHA for 2095965

• Trim trailing empty lines and whitespaces

  Julow

  committed
  606447a

  Copy full SHA for 606447a

Commits on Jun 2, 2023

• Preserve empty trailing lines in doc comments

  Julow

  committed
  4572014

  Copy full SHA for 4572014

• Restore formatting of cinaps comments

  Julow

  committed
  3468395

  Copy full SHA for 3468395

• Preserve pro/epi break on comments as doc

  Julow

  committed
  aa80541

  Copy full SHA for aa80541

Commits on Jun 5, 2023

• Fix regressions on unwrapped comments

  Julow

  committed
  364fc75

  Copy full SHA for 364fc75

• Fix parsing of asterisk prefixed comments

  Julow

  committed
  e009001

  Copy full SHA for e009001

• Restore break before preceeding multi-line comments

  Show description for 7bff959
  Julow

  committed
  7bff959

  Copy full SHA for 7bff959

• Preserve leading/trailing newlines in unwrapped comments

  Julow

  committed
  f8719ba

  Copy full SHA for f8719ba

Commits on Jun 6, 2023

• Tests: Remove no longer necessary --max-iter

  Julow

  committed
  69f2a8e

  Copy full SHA for 69f2a8e

• Tests: Remove empty .err files

  Julow

  committed
  5a56bf1

  Copy full SHA for 5a56bf1

• Fix parsing and printing of header-like comments

  Show description for 37bf3f0
  Julow

  committed
  37bf3f0

  Copy full SHA for 37bf3f0

• Update changes

  Julow

  committed
  8bf52f2

  Copy full SHA for 8bf52f2

• Fix parsing of asterisk prefixed comments too open

  Julow

  committed
  cf878da

  Copy full SHA for cf878da

• Merge branch 'main' into cmts-factor

  Julow

  committed
  00a77f3

  Copy full SHA for 00a77f3

Commits on Jun 7, 2023

• Cleanup Cmt

  gpetiot

  committed
  6e0ae10

  Copy full SHA for 6e0ae10

• Don't check the margin to group comments

  gpetiot

  committed
  9a5bb99

  Copy full SHA for 9a5bb99

• Merge pull request #1 from gpetiot/cmts-factor-dont-check-margin

  Show description for fe93ffd
  Julow

  authored
  fe93ffd

  Copy full SHA for fe93ffd

• Even less open parsing of asterisk prefixed

  Show description for 58e8d0b
  Julow

  committed
  58e8d0b

  Copy full SHA for 58e8d0b

• Change the baseline indentation for unwrapped comments

  Show description for f4f64ca
  Julow

  committed
  f4f64ca

  Copy full SHA for f4f64ca

• Fix interference between f4f64ca and 58e8d0b

  Julow

  committed
  017935d

  Copy full SHA for 017935d

• Don't unindent unwrapped comments

  Julow

  committed
  1ee288d

  Copy full SHA for 1ee288d

• Fix last line of asterisk prefixed

  Julow

  committed
  09a9638

  Copy full SHA for 09a9638

• Make Cmt.t abstract

  Julow

  committed
  b92c62f

  Copy full SHA for b92c62f

• Don't mix comments and docstrings

  Show description for 25aa14c
  Julow

  committed
  25aa14c

  Copy full SHA for 25aa14c

Commits on Jun 8, 2023

• Make Cmt.t abstract

  Show description for cd00fe6
  Julow

  committed
  cd00fe6

  Copy full SHA for cd00fe6

• Don't mix comments and docstrings

  Show description for ef208e9
  Julow

  committed
  ef208e9

  Copy full SHA for ef208e9

• Merge branch 'cmts-docstrings' into cmts-factor

  Julow

  committed
  2ef7270

  Copy full SHA for 2ef7270

• Merge branch 'main' into cmts-factor

  Julow

  committed
  7633f3e

  Copy full SHA for 7633f3e

Commits on Jun 9, 2023

• Normalize comments inside comments

  Julow

  committed
  c37b6ad

  Copy full SHA for c37b6ad

Commits on Jun 12, 2023

• Add ocaml-ppx#2372 to changelog

  Julow

  committed
  8a4e1cf

  Copy full SHA for 8a4e1cf

• Merge branch 'main' into cmts-factor

  Julow

  committed
  e000e31

  Copy full SHA for e000e31

Commits on Jun 22, 2023

• Merge branch 'main' into cmts-factor

  Julow

  committed
  e273379

  Copy full SHA for e273379

Commits on Jun 23, 2023

• Move break out of fmt_cmt

  Julow

  committed
  ca35745

  Copy full SHA for ca35745

• Revert change to test break_separators.ml

  Julow

  committed
  27a0074

  Copy full SHA for 27a0074

Commits on Sep 19, 2023

• Remove unecessary test 'asterisk_prefixed_cmts'

  Julow

  committed
  fcf2b80

  Copy full SHA for fcf2b80

• Merge branch 'MAIN' into cmts-factor

  Julow

  committed
  0c95f7e

  Copy full SHA for 0c95f7e

Commits on Oct 26, 2023

• Merge branch 'MAIN' into cmts-factor

  Julow

  committed
  418f8c3

  Copy full SHA for 418f8c3

• Add testcase for ocaml-ppx#2468

  Julow

  committed
  8f3d799

  Copy full SHA for 8f3d799

Commits on Nov 2, 2023

• Add test variant for unwrapped comments

  Julow

  committed
  971df85

  Copy full SHA for 971df85

• Preserve trailing empty line of unwrapped comments

  Julow

  committed
  bce8df8

  Copy full SHA for bce8df8

Commits on Nov 6, 2023

• Merge branch 'MAIN' into cmts-factor

  Julow

  committed
  20f4fb8

  Copy full SHA for 20f4fb8

• test: Add non-stabilizing comment

  Julow

  committed
  c86b00c

  Copy full SHA for c86b00c

• Fix non-stabilizing comment

  Show description for 907d70a
  Julow

  committed
  907d70a

  Copy full SHA for 907d70a

Commits on Nov 7, 2023

• Fix regression (break introduced before the end of a paragraph)

  gpetiot

  committed
  a400535

  Copy full SHA for a400535

• Don't trim first line of asterisk prefixed comment

  Julow

  committed
  a0c9aae

  Copy full SHA for a0c9aae

• Add test case from ocaml-ppx#2469

  Julow

  committed
  5f5532e

  Copy full SHA for 5f5532e

• test: Fix spacing in cinaps.ml

  Show description for 86e12c3
  Julow

  committed
  86e12c3

  Copy full SHA for 86e12c3