Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize pretty printing of class_infos, open_infos and include_infos #2500

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Factorize pretty printing of class_infos, open_infos and include_infos #2500

merged 1 commit into from
Dec 21, 2023

Conversation

gpetiot
Copy link
Collaborator

@gpetiot gpetiot commented Dec 21, 2023

No description provided.

@gpetiot gpetiot added the no changelog set this to bypass the CI check for changelog entries label Dec 21, 2023
@gpetiot gpetiot force-pushed the printast-class-infos branch from 44457ec to b31bbef Compare December 21, 2023 05:16
@gpetiot gpetiot changed the title Factorize pretty printing of 'a class_infos types Factorize pretty printing of class_infos, open_infos and include_infos Dec 21, 2023
@gpetiot gpetiot merged commit 11460fa into ocaml-ppx:main Dec 21, 2023
9 of 10 checks passed
@gpetiot gpetiot deleted the printast-class-infos branch December 21, 2023 05:24
Julow
Julow reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be careful that we need to backport changes from upstream into this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Julow left review comments

Assignees
No one assigned
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpetiot @Julow