Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 5.2 changes to parser-standard #2512

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

Julow
Copy link
Collaborator

@Julow Julow commented Jan 22, 2024

AST changes, perhaps due to parser-extended not being uptodate.
This might depend on #2503

@Julow Julow added the no changelog set this to bypass the CI check for changelog entries label Jan 22, 2024
@gpetiot
Copy link
Collaborator

gpetiot commented Jan 22, 2024

This only impacts parser-standard, which parser-extended doesn't depend on. This will be good to go as soon as the tests are passing.

@Julow
Copy link
Collaborator Author

Julow commented Jan 22, 2024

The tests are not passing due AST changes, which I think are due to parser-extended not being uptodate.

gpetiot and others added 2 commits January 23, 2024 11:05
TODO: Compiler libs shims are needed in Load_path and Builtin_attributes.
@gpetiot gpetiot force-pushed the backport-52-standard branch from f24bbe0 to b86e1a9 Compare January 23, 2024 10:07
@Julow Julow mentioned this pull request Feb 9, 2024
@Julow
Copy link
Collaborator Author

Julow commented Feb 9, 2024

Merged over #2519

@Julow Julow marked this pull request as ready for review October 8, 2024 14:03
@Julow Julow changed the title WIP: Backport 5.2 changes to parser-standard Backport 5.2 changes to parser-standard Oct 8, 2024
@Julow
Copy link
Collaborator Author

Julow commented Oct 8, 2024

This PR is changed to backport the remaining parser and lexer changes except for Pexp_function, which is being worked on in #2544

text appears first in the list.
*)

%inline nonempty_concat(X):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is not used but will be in #2544

@Julow Julow merged commit 7f20ec4 into ocaml-ppx:main Oct 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants