test: Test all profiles #2618
Merged
test: Test all profiles #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run formatting on every test files for every profiles. Rules are
generated for each profiles and output files (.ref and .err) are now in
test/passing/refs.<profile name>/
The main reason for this change is to increase the coverage for the
default profile, which was barely tested.
This also avoids tests without a ref file, which are frustrating to work
with.
The '.ref' extension for output files is not dropped to avoid confusing
output files for input files.
Julow
added
the
no changelog
The coverage for the janestreet profile is much better than before and all of these cases are already covered in source.ml.
This is no longer needed
Rewrite the command to use the `refs.*/.ocamlformat` belonging to each profiles and include the same dune.inc in each output dirs. 'verbose1.ml' test is removed because it doesn't work well with the `--name` option. The size of the dune file is also slightly reduced because the (package) stanza could be removed.
Julow
added a commit
to Julow/ocamlformat
that referenced
this pull request
Nov 29, 2024
Bug introduced in ocaml-ppx#2618. The tests don't pass when run with `dune build -p` option, as it's done in Opam.
Julow
added a commit
that referenced
this pull request
Nov 29, 2024
Bug introduced in #2618. The tests don't pass when run with `dune build -p` option, as it's done in Opam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run formatting on every test files for every profiles. Rules are generated for each profiles and output files (.ref and .err) are now in
The main reason for this change is to increase the coverage for the default profile, which was barely tested.
This also avoids tests without a ref file, which are frustrating to work with.
The '.ref' extension for output files is not dropped to avoid confusing output files for input files.