[new release] ppx_import (1.10.0) #21530
Conversation
CHANGES: * Update ppxlib to 0.26.0 (ocaml-ppx/ppx_import#69, @pitag-ha)
| "dune" { >= "1.11.0" } | ||
| "ppxlib" { >= "0.26.0" } | ||
| "ounit" { with-test } | ||
| "ppx_deriving" { with-test & >= "4.2.1" } |
There was a problem hiding this comment.
I think this will make ppx_import -with-test uninstallable on OCaml 4.09 downwards.
There was a problem hiding this comment.
I’m not seeing it. How so? (also this was already there in the original formula)
There was a problem hiding this comment.
because of ppxlib 0.26 API being not compatible
There was a problem hiding this comment.
ppx_deriving < 5.0 does not use ppxlib
There was a problem hiding this comment.
There was a problem hiding this comment.
ppx_deriving is fine, but note you are not installing ppx_sexp_conv (and the dune file disable these tests)
I'm a bit lost on what you mean here.
There was a problem hiding this comment.
I’m lost as well. CI shows everything working on 4.05 upwards so I’m merging. Thanks a lot!
There was a problem hiding this comment.
Could you return the fixes to the opam file upstream?
There was a problem hiding this comment.
The change is already pushed upstream.
I’m lost as well. CI shows everything working on 4.05 upwards so I’m merging. Thanks a lot!
It is working because you placed the or constraint, my comment was for the version without the or constraint, which can't possible work.
Thanks!
There was a problem hiding this comment.
In particular note this https://github.com/ocaml-ppx/ppx_import/blob/master/src_test/ppx_deriving_sexp/dune#L3
A syntax extension for importing declarations from interface files
CHANGES: