Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework healthcheck system #108

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Rework healthcheck system #108

merged 5 commits into from
Jul 23, 2020

Conversation

aboulay
Copy link
Contributor

@aboulay aboulay commented Jul 20, 2020

  • Add readiness in the proxy to show node status per type.
  • Rework the /status page to show proxy carthagenet and current nodes status per types.

@aboulay aboulay added the app Feature on the applicative part of the project label Jul 20, 2020
@aboulay aboulay self-assigned this Jul 20, 2020
@aboulay aboulay linked an issue Jul 20, 2020 that may be closed by this pull request
Update /status page in the frontend #107
Closed
@aboulay
Copy link
Contributor Author

aboulay commented Jul 20, 2020

The new status page:

Capture d’écran 2020-07-20 à 11 45 31

@aboulay aboulay marked this pull request as ready for review July 20, 2020 10:04
louptheron
louptheron reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR ! I added few comments

web/src/pages/Status/Status.view.tsx Outdated Show resolved Hide resolved
web/src/pages/Status/Status.view.tsx Outdated Show resolved Hide resolved
web/src/pages/Status/Status.view.tsx Outdated Show resolved Hide resolved
@frankhillard
Copy link
Collaborator

This PR produces a debt. We need to create a integration test => #110

@frankhillard frankhillard merged commit 768e9c4 into master Jul 23, 2020
@aboulay aboulay deleted the rework-healthcheck-system branch July 23, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louptheron louptheron louptheron left review comments

@frankhillard frankhillard frankhillard approved these changes

@AymericBethencourt AymericBethencourt Awaiting requested review from AymericBethencourt

Assignees

@aboulay aboulay

Labels
app Feature on the applicative part of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update /status page in the frontend
3 participants
@aboulay @frankhillard @louptheron