Move validate_data to base EMR viewset and add slot_type filter in availability query

[rithviknishad]

Proposed Changes

• Move validate_data to base EMR viewset
• Add slot_type filter in availability query

Associated Issue

• Link to issue here, explain how the proposed solution will solve the reported issue/ feature request.

Architecture changes

• Remove this section if not used

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete
• Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

• Bug Fixes
  • Updated availability statistics to only consider appointment slots
  • Restored data validation method placeholder in base viewset

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces two distinct modifications in the EMR API viewsets. First, the EMRBaseViewSet in base.py reintroduces a placeholder validate_data method, potentially setting the stage for future data validation. Secondly, in the availability.py file, the availability_stats method is updated to filter availabilities specifically for appointment slots, narrowing the scope of slot retrieval.

Changes

File	Change Summary
care/emr/api/viewsets/base.py	Reinstated validate_data method with empty implementation in EMRBaseViewSet
care/emr/api/viewsets/scheduling/availability.py	Added slot_type=SlotTypeOptions.appointment.value filter to availability query

Possibly related PRs

• Appointments: Filters and fix available_doctors API #2686: Changes in TokenBookingFilters and TokenBookingViewSet related to appointment functionality

Suggested reviewers

• vigneshhari

Poem

Slots and methods, dancing light,
Validation's ghost returns to sight 🕹️
Appointments filtered, precise and clean
In EMR's digital routine 🩺
Code evolves, a subtle art 💻

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46a8f7a and d6642e8.

📒 Files selected for processing (2)

• care/emr/api/viewsets/base.py (1 hunks)
• care/emr/api/viewsets/scheduling/availability.py (1 hunks)

🔇 Additional comments (1)

care/emr/api/viewsets/scheduling/availability.py (1)

226-227: The addition of slot_type filter is good, but double-check downstream behaviors.

Ensuring only appointment slots are considered is noteworthy, and presumably aligns with your new logic. You might confirm elsewhere that no other slot types were inadvertently excluded.

[coderabbitai]

🛠️ Refactor suggestion

Consider removing or elaborating this placeholder method.

Currently, validate_data does nothing and might mislead future maintainers. If it’s truly needed, please implement a real validation routine; otherwise, removing it might keep the codebase simpler.