Adding App Bundle (AAB) support, with tasks. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Removing deprecated tasks, so that I don't have to generate extra deprecated tasks for the aab variants.
oliviergauthier
added a commit
that referenced
this pull request
Sep 7, 2021
This reverts commit e21601b. # Conflicts: # src/main/kotlin/com/betomorrow/gradle/appcenter/AppCenterPlugin.kt # src/main/kotlin/com/betomorrow/gradle/appcenter/infra/AppCenterUploader.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an extra task appCenterUploadAab, next to appCenterUploadApk.
Removing deprecated tasks, so that I don't have to generate extra deprecated tasks for the aab variants.
This PR is loosely based on:
#71
With the main difference being, that you don't need to lock a flavor to either AAB or APK with an "artifactType" parameter, but instead you get two separate tasks for the two separate publish types. This seems to match more with the pattern the plugin is already using, as we already have appCenterUploadApk appCenterUploadMapping and appCenterUploadSymbols.
Sadly, you still can't distribute AAB-s to destinations, so I had to remove that bit as well for appCenterUploadAab tasks.
There's one thing I'm unsure about. Currently I made appCenterUpload depend on all 4 of: appCenterUploadApk, appCenterUploadAab, appCenterUploadMapping and appCenterUploadSymbols. This is exactly what I need in my application. But others might find it excessive to upload both Apk and Aab. However, it's not a big deal, because then they can just manually name which bits they want to upload.