Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional empty line when output option is not specified #11

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

scintillavoy
Copy link
Contributor

👋 Hi. I'm trying out Handlebars and came across this repository.

I found results are inconsistent depending on whether the --output option is specified or not. If the option is not specified, the output has one more empty line in the end because of println!.

# This works as expected.
hbs-cli <properties file> <template file> -o <output file>

# It produces an additional empty line in the end, which is inconsistent with the above.
hbs-cli <properties file> <template file> > <output file>

I just made a small change. Thanks.

@olorin37
Copy link
Owner

olorin37 commented Jul 4, 2024

Thank you for contribution.

I just found, thanks to your PR, that whole description of --outputis out-of-date😨

    /// Not implemented parameter for output file name if not provided output

While output is implemented, of course. No worries, i am intenting to rewrite CLI to clap, as after years structopt was "merged" to it, so I'll fix strings using the opportunity.

Copy link
Owner

@olorin37 olorin37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it.

@olorin37 olorin37 merged commit 4554d2a into olorin37:master Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants