Making reference to image IDs not contained in a pack negative in Figures #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #82 - in short, currently we have an undefined behavior regarding image IDs in Figures. for Images contained in a pack, references to their IDs are updated in transferred figures to point to the destination ID; for all other images in those figures, their IDs are untouched.
In practice, this can mean that Figures will have empty panels (in case the source ID for non-pack images do not exist/are outside permissions in the destination side) or have "wrong" images (in case the source ID is accessible destination-side).
This PR changes all non-pack image IDs to
-1- that ensures that 1) the inconsistent behavior described is eliminated, panels will always be empty; 2) clearly signals to users that this is a deliberate choice; 3) indicates that those images were not part of the pack.