fix(overwrites): perform deep clone

Signed-off-by: Till Sanders <mail@till-sanders.de>
open-election-compass · Aug 22, 2022 · 1292e4b · 1292e4b
1 parent 49c8938
commit 1292e4b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@open-election-compass/client",
-  "version": "2.0.0-alpha.3",
+  "version": "2.0.0-alpha.4",
   "author": "Till Sanders <mail@till-sanders.de>",
   "license": "GPL-3.0",
   "main": "dist/open-election-compass.umd.min.js",

diff --git a/src/store/modules/languages/languages.js b/src/store/modules/languages/languages.js
@@ -1,5 +1,6 @@
 import getUserLocale from 'get-user-locale';
 import i18n from '/src/locales/i18n';
+import cloneDeep from 'lodash/cloneDeep';
 
 const officialLanguages = ['ar', 'de', 'en', 'es', 'fr', 'hu', 'id', 'it', 'nl', 'pl', 'pt', 'tr'];
 
@@ -39,7 +40,7 @@ export default {
         );
       }
       if (typeof language.overwrites === 'object' && language.overwrites !== null) {
-        i18n.global.mergeLocaleMessage(language.code, language.overwrites);
+        i18n.global.mergeLocaleMessage(language.code, cloneDeep(language.overwrites));
       }
       state.languages.push({
         code: language.code,
@@ -70,10 +71,8 @@ export default {
         ...translations.content,
         ui: translations.ui,
       });
-      console.log('overwriting', language, language.overwrites);
       if (typeof language.overwrites === 'object' && language.overwrites !== null) {
-        console.log('overwritten', language, language.overwrites);
-        i18n.global.mergeLocaleMessage(language.code, language.overwrites);
+        i18n.global.mergeLocaleMessage(language.code, cloneDeep(language.overwrites));
       }
     },
     setFallbackLanguage(state, code) {