[otelcol] Tell all loggers to encode timestamps in ISO8601. #10543
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10543 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 447 447
Lines 23721 23723 +2
=======================================
+ Hits 21694 21696 +2
Misses 1653 1653
Partials 374 374 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM. Please add a changelog entry. IMO this is best documented as a breaking change since it may affect users who are consuming the collector's logs.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Sorry, still planning to work on this. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
added
ready-to-merge
djaglowski
added
the
ready-to-merge
…emetry#10543) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description OTel collector log messages in Windows are currently displayed in scientific notation, e.g.: ``` 1.7194132367192364e+09 error scraperhelper/scrapercontroller.go:197 Error scraping metrics … ``` This fix will cause the log messages to use ISO8601 timestamps instead. <!--Describe what testing was performed and which tests were added.--> #### Testing Manual testing. <!--Describe the documentation added.--> #### Documentation The previous behavior was undocumented, so no documentation changes needed. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Description
OTel collector log messages in Windows are currently displayed in scientific notation, e.g.:
This fix will cause the log messages to use ISO8601 timestamps instead.
Testing
Manual testing.
Documentation
The previous behavior was undocumented, so no documentation changes needed.