[envprovider] - If env is set to empty string, fallback to default #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
env-bugfix
branch
from
679590f to
f431de6
Compare
dmitryax
requested changes
Dec 2, 2024
There was a problem hiding this comment.
It needs discussion before changing the behaviour. See #11531 (comment)
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
After some thought over Dmitry's comment,
I agree. I'll close this issue. I think it's better to consider the empty string because the user might have explicitly set it to "". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11531 (comment)
In my opinion, we should fallback to default when either: