Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: update to latest major version #11781

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[chore]: update to latest major version #11781

merged 1 commit into from
Dec 2, 2024

Conversation

VihasMakwana
Copy link
Contributor

Unblocks #11775.

@VihasMakwana VihasMakwana requested a review from a team as a code owner December 2, 2024 15:32
@VihasMakwana
Copy link
Contributor Author

Just a thought:

Shouldn't this be automated like defaultBetaOtelColVersion?

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (c52d625) to head (0cb9d89).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11781   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         447      447           
  Lines       23721    23721           
=======================================
  Hits        21694    21694           
  Misses       1653     1653           
  Partials      374      374

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Dec 2, 2024

Shouldn't this be automated like defaultBetaOtelColVersion?

Yes, it should! Would you want to work on this?

@mx-psi mx-psi added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@VihasMakwana
Copy link
Contributor Author

@mx-psi sure. I'll work on it as a follow up.

@mx-psi mx-psi mentioned this pull request Dec 2, 2024
Closed
@bogdandrutu bogdandrutu merged commit 97929ac into open-telemetry:main Dec 2, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 2, 2024
@jade-guiton-dd jade-guiton-dd mentioned this pull request Dec 3, 2024
Closed
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@VihasMakwana @HongChenTW
[chore]: update to latest major version (open-telemetry#11781)
932d69a 
Unblocks
open-telemetry#11775.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.115.0
Development

Successfully merging this pull request may close these issues.
3 participants
@VihasMakwana @mx-psi @bogdandrutu