Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scraper for logs #11799

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Add scraper for logs #11799

merged 8 commits into from
Dec 10, 2024

Conversation

sincejune
Copy link
Contributor

@sincejune sincejune commented Dec 4, 2024

Description

Add scraper for logs

Link to tracking issue

Relates to #11238

Testing

Added unit tests

Documentation

Added

@sincejune sincejune requested a review from a team as a code owner December 4, 2024 16:37
@sincejune sincejune requested a review from atoulme December 4, 2024 16:37
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (436df17) to head (cb17053).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11799   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         445      446    +1     
  Lines       23731    23743   +12     
=======================================
+ Hits        21733    21745   +12     
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add this to the factory.

@sincejune
Copy link
Contributor Author

You also need to add this to the factory.

I'll add this change in the next PR.

@sincejune
Copy link
Contributor Author

You also need to add this to the factory.

I'll add this change in the next PR.

Added in #11822 cc @bogdandrutu

@bogdandrutu bogdandrutu added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@mx-psi mx-psi added this pull request to the merge queue Dec 10, 2024
Merged via the queue into open-telemetry:main with commit 470c0dd Dec 10, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 10, 2024
@sincejune sincejune deleted the add-logs-scraper branch December 10, 2024 10:50
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add scraper for logs

<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to open-telemetry#11238 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added unit tests

<!--Describe the documentation added.-->
#### Documentation
Added

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants