[chore] Fix bug in exporter.Request.MergeSplit() #12009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
logsRequest
,tracesRequest
andmetricsRequest
to NOT modify the input ifMergeSplit()
returns an error. Copy-pasted the doc string ofMergeSplit()
for references:// MergeSplit is a function that merge and/or splits this request with another one into multiple requests based on the
// configured limit provided in MaxSizeConfig.
// All the returned requests MUST have a number of items that does not exceed the maximum number of items.
// Size of the last returned request MUST be less or equal than the size of any other returned request.
// The original request MUST not be mutated if error is returned after mutation or if the exporter is
// marked as not mutable. The length of the returned slice MUST not be 0.
// Experimental: This API is at the early stage of development and may change without backward compatibility
// until #8122 is resolved.
MergeSplit(context.Context, exporterbatcher.MaxSizeConfig, Request) ([]Request, error)
Link to tracking issue
Fixes #
Testing
Added
TestMergeSplit{Logs, Traces, Metrics}InputNotModifiedIfErrorReturned
Documentation