Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test #1623

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fix flaky test #1623

merged 1 commit into from
Dec 24, 2024

Conversation

trask
Copy link
Member

@trask trask commented Dec 24, 2024 

ConsistentReservoirSamplingSpanProcessorTest > ignoresNullSpans() FAILED
    java.lang.NullPointerException
        at io.opentelemetry.contrib.sampler.consistent.ConsistentReservoirSamplingSpanProcessor$Worker.lambda$shutdown$1(ConsistentReservoirSamplingSpanProcessor.java:522)
        at io.opentelemetry.sdk.common.CompletableResultCode.whenComplete(CompletableResultCode.java:189)
        at io.opentelemetry.contrib.sampler.consistent.ConsistentReservoirSamplingSpanProcessor$Worker.shutdown(ConsistentReservoirSamplingSpanProcessor.java:518)
        at io.opentelemetry.contrib.sampler.consistent.ConsistentReservoirSamplingSpanProcessor$Worker.access$900(ConsistentReservoirSamplingSpanProcessor.java:433)
        at io.opentelemetry.contrib.sampler.consistent.ConsistentReservoirSamplingSpanProcessor.shutdown(ConsistentReservoirSamplingSpanProcessor.java:420)
        at io.opentelemetry.contrib.sampler.consistent.ConsistentReservoirSamplingSpanProcessorTest.ignoresNullSpans(ConsistentReservoirSamplingSpanProcessorTest.java:256)

@trask trask requested a review from a team as a code owner December 24, 2024 17:27
@github-actions github-actions bot requested review from oertl and PeterF778 December 24, 2024 17:27
@trask trask merged commit 0d77587 into open-telemetry:main Dec 24, 2024
14 checks passed
@trask trask deleted the fix-flaky-test branch December 24, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@oertl oertl Awaiting requested review from oertl

@PeterF778 PeterF778 Awaiting requested review from PeterF778

Assignees

@oertl oertl

@PeterF778 PeterF778

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trask @laurit @oertl @PeterF778