Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): broken link for community contribution lifecycle and processes #5206

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 26, 2024

Which problem is this PR solving?

The current link is broken https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md

Fixes # (issue)

Short description of the changes

Fixes the broken link for contribution processes which were moved in open-telemetry/community#2051

Type of change

Please delete options that are not relevant.

  • This change is a documentation update

How Has This Been Tested?

Checklist:

  • Followed the style guidelines of this project
  • Documentation has been updated

@trivikr trivikr requested a review from a team as a code owner November 26, 2024 23:32
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (e80879e) to head (5fe5b0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5206      +/-   ##
==========================================
- Coverage   94.59%   94.58%   -0.02%     
==========================================
  Files         314      314              
  Lines        7993     7993              
  Branches     1611     1611              
==========================================
- Hits         7561     7560       -1     
- Misses        432      433       +1     

see 1 file with indirect coverage changes

@trivikr
Copy link
Contributor Author

trivikr commented Nov 26, 2024

The changelog CI failed

Please add a CHANGELOG entry, or add the "Skip Changelog" label if not required.

This is a minor change, for which CHANGELOG entry can be skipped and Skip changelog label can be added.

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks.
Would you be willing to update these other two references as well?

% rg community/blob/.*?/CONTRIBUTING.md
.github/PULL_REQUEST_TEMPLATE.md
10:  - See https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md#sign-the-cla

CONTRIBUTING.md
82:[guide](https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md)
148:Please also see [GitHub workflow](https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md#github-workflow) section of general project contributing guide.

experimental/packages/otlp-transformer/protos/CONTRIBUTING.md
4:guide](https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md)

I think the #github-workflow content has actually moved to a different file:
https://github.com/open-telemetry/community/blob/main/guides/contributor/processes.md#github-workflow

@trivikr
Copy link
Contributor Author

trivikr commented Nov 27, 2024

@trentm I've updated the links in current repo.

The opentelemetry-proto is a submodule, and it was fixed there in open-telemetry/opentelemetry-proto#573
It'll be fixed in this repo when the submodule is updated.

@pichlermarc
Copy link
Member

pichlermarc commented Nov 27, 2024

@trentm I've updated the links in current repo.

The opentelemetry-proto is a submodule, and it was fixed there in open-telemetry/opentelemetry-proto#573 It'll be fixed in this repo when the submodule is updated.

Thanks for looking into it, I created an issue to track this - the submodule is quite outdated (#5208)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@pichlermarc pichlermarc added this pull request to the merge queue Nov 27, 2024
Merged via the queue into open-telemetry:main with commit 561f8ad Nov 27, 2024
21 checks passed
@trivikr trivikr deleted the patch-1 branch November 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants