-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): broken link for community contribution lifecycle and processes #5206
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5206 +/- ##
==========================================
- Coverage 94.59% 94.58% -0.02%
==========================================
Files 314 314
Lines 7993 7993
Branches 1611 1611
==========================================
- Hits 7561 7560 -1
- Misses 432 433 +1 |
The changelog CI failed
This is a minor change, for which CHANGELOG entry can be skipped and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks.
Would you be willing to update these other two references as well?
% rg community/blob/.*?/CONTRIBUTING.md
.github/PULL_REQUEST_TEMPLATE.md
10: - See https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md#sign-the-cla
CONTRIBUTING.md
82:[guide](https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md)
148:Please also see [GitHub workflow](https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md#github-workflow) section of general project contributing guide.
experimental/packages/otlp-transformer/protos/CONTRIBUTING.md
4:guide](https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md)
I think the #github-workflow
content has actually moved to a different file:
https://github.com/open-telemetry/community/blob/main/guides/contributor/processes.md#github-workflow
@trentm I've updated the links in current repo. The |
Thanks for looking into it, I created an issue to track this - the submodule is quite outdated (#5208) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙌
Which problem is this PR solving?
The current link is broken https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md
Fixes # (issue)
Short description of the changes
Fixes the broken link for contribution processes which were moved in open-telemetry/community#2051
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: