Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esm suport #5298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xiaoxiangmoe
Copy link

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

check compiled dist has no require('...') expression

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@xiaoxiangmoe xiaoxiangmoe requested a review from a team as a code owner December 25, 2024 15:13
Copy link

linux-foundation-easycla bot commented Dec 25, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@Netail
Copy link

Netail commented Dec 27, 2024

The requires were inline for lazy loading

@xiaoxiangmoe
Copy link
Author

xiaoxiangmoe commented Dec 27, 2024

@Netail This is not too much code so it it not needed for use lazy loading. Also, use require in esm is illegal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants