ci: 202 is Accepted for a non-dead link.

[scbjans]

The Markdown Link Check job occasionally checks a link on rubydoc.info which needs to be rendered. In that case a HTTP 202 is returned.
However that leads to an error, e.g. here:

ERROR: 1 dead links found!
[✖] https://www.rubydoc.info/gems/opentelemetry-propagator-ottrace → Status: 202

A HTTP 202 should be Accepted.

[arielvalentin]

Any idea why the action is failing?

[xuan-cao-swi]

ERROR: 1 dead links found!
[✖] https://opensource.org/licenses/MIT → Status: 403

I curl the link returns HTTP/2 301. I guess the ci/action exceed the rate limit for the opensource.org?

[scbjans]

ERROR: 1 dead links found!
[✖] https://opensource.org/licenses/MIT → Status: 403

I curl the link returns HTTP/2 301. I guess the ci/action exceed the rate limit for the opensource.org?

I would expect a 429 in that case..? Anyway, I see the author of the action recommends switching to Linkspector. So maybe we should close this PR and put some effort into migrating to Linkspector?

[arielvalentin]

Probably.

Another thing we may want to try is only run the action if it detects changes to markdown files.

[scbjans]

I'd expect the markdownlink check action doesn't send a Host header triggering some kind of ddos protection?

curl -I -H 'Host:' --http1.0 https://opensource.org/licenses/MIT
HTTP/1.1 403 Forbidden

Probably.

Another thing we may want to try is only run the action if it detects changes to markdown files.

Running this action only on modified files will not catch links in other files going dead over time.
Maybe this action shouldn't run on.pull_request but on.schedule?

If time permits I'll look into Linkinspector end of this week, or beginning of next week.

[github-actions]

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot