Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Conventional Commit Lint #821

Closed

Conversation

arielvalentin
Copy link
Collaborator

This is an attempt to add conventional commit lint.

It is an alternative to #800

@arielvalentin arielvalentin self-assigned this Jan 17, 2024
@arielvalentin arielvalentin force-pushed the add-commitlint-gh-action branch from 989a3b3 to 0a4b299 Compare January 17, 2024 04:23
@arielvalentin arielvalentin force-pushed the add-commitlint-gh-action branch from 4278776 to b54c6df Compare January 17, 2024 04:26
@arielvalentin arielvalentin changed the title ci: Add Conventional Commit Lint ci!: Add Conventional Commit Lint Jan 17, 2024
@arielvalentin arielvalentin force-pushed the add-commitlint-gh-action branch from 86f22dc to 42581d7 Compare January 17, 2024 04:44
@arielvalentin arielvalentin force-pushed the add-commitlint-gh-action branch from 6c639b6 to 5359c0b Compare January 17, 2024 04:56
@arielvalentin arielvalentin changed the title ci!: Add Conventional Commit Lint Add Conventional Commit Lint Jan 17, 2024
@arielvalentin arielvalentin changed the title Add Conventional Commit Lint ci: Add Conventional Commit Lint Jan 17, 2024
@arielvalentin
Copy link
Collaborator Author

arielvalentin commented Jan 17, 2024

@scbjans @kaylareopelle I got something working but it required two different GitHub actions to get what I wanted.

  1. Action checks the PR title
  2. Action that checks individual commit messages

Now trying merge commit messages...

@arielvalentin
Copy link
Collaborator Author

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielvalentin - Yay! I'm so glad it's working. I have two questions.

Comment on lines +28 to +36
fix
feat
chore
ci
docs
style
refactor
perf
test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fix
feat
chore
ci
docs
style
refactor
perf
test
chore
ci
docs
feat
fix
perf
refactor
style
test

Mind if we alphabetize this list?

Also, the list in commitlint.config.js also includes revert and squash. Should those be here too?

@scbjans
Copy link
Contributor

scbjans commented Jan 18, 2024

yup... seems like merge commits are ok https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/7551640637/job/20559186184?pr=821

Yoohoo! Is there a limit on the number of GH actions we can use?
If so #800 seems to be unblocked now; so that would be more favorable then Nevermind, reading is hard...

@arielvalentin
Copy link
Collaborator Author

closed in favor of #800

@arielvalentin arielvalentin deleted the add-commitlint-gh-action branch January 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants