-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add Conventional Commit Lint #821
ci: Add Conventional Commit Lint #821
Conversation
989a3b3
to
0a4b299
Compare
4278776
to
b54c6df
Compare
86f22dc
to
42581d7
Compare
6c639b6
to
5359c0b
Compare
@scbjans @kaylareopelle I got something working but it required two different GitHub actions to get what I wanted.
Now trying merge commit messages... |
yup... seems like merge commits are ok https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/7551640637/job/20559186184?pr=821 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielvalentin - Yay! I'm so glad it's working. I have two questions.
fix | ||
feat | ||
chore | ||
ci | ||
docs | ||
style | ||
refactor | ||
perf | ||
test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix | |
feat | |
chore | |
ci | |
docs | |
style | |
refactor | |
perf | |
test | |
chore | |
ci | |
docs | |
feat | |
fix | |
perf | |
refactor | |
style | |
test |
Mind if we alphabetize this list?
Also, the list in commitlint.config.js
also includes revert
and squash
. Should those be here too?
Yoohoo! Is there a limit on the number of GH actions we can use? |
closed in favor of #800 |
This is an attempt to add conventional commit lint.
It is an alternative to #800