Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr][upstream] fr_FR dictionary is missing many common words #5870

Open
chalin opened this issue Jan 4, 2025 · 4 comments
Open

[fr][upstream] fr_FR dictionary is missing many common words #5870

chalin opened this issue Jan 4, 2025 · 4 comments
Labels
CI/infra CI & infrastructure i18n internationalization lang:fr upstream

Comments

@chalin
Copy link
Contributor

chalin commented Jan 4, 2025

Originally posted by @chalin in #5833 (comment)

Adding the 152 missing words to the dictionary for this PR doesn't seem like a sustainable solution.

I agree that it isn't optimal nor sustainable.

Do you have any suggestions for addressing this issue more effectively?

Submitting PR(s) upstream to https://github.com/streetsidesoftware/cspell-dicts; for example, the last update seems to be streetsidesoftware/cspell-dicts#680. Any volunteers? It would be of benefit to all projects that use cSpell's fr_FR dictionaries.


References:

/cc @open-telemetry/docs-fr-approvers

@chalin
Copy link
Contributor Author

chalin commented Jan 4, 2025

It might be worth first inquiring with the maintainer. Most other languages have complete dictionaries out-of-the-box. It seems strange that the French one is so incomplete. It could be a build issue rather than an issue with the collection of words? Does anyone want to lead the investigation, maybe first opening an issue over streetsidesoftware/cspell-dicts?

@chalin
Copy link
Contributor Author

chalin commented Jan 4, 2025

It might also be worth asking what the fr Kubernetes folks using for spell checking, https://kubernetes.slack.com/archives/CG838BFT9 (#kubernetes-docs-fr).

Edit: I just posted a question, asking whether the K8s docs-fr folks used cSpell or not, see https://kubernetes.slack.com/archives/CG838BFT9/p1736018451325119.

@bertysentry
Copy link
Contributor

Maybe we're just missing - fr-fr in the list of dictionaries in .cspell.yml?

@chalin
Copy link
Contributor Author

chalin commented Jan 6, 2025

Maybe we're just missing - fr-fr in the list of dictionaries in .cspell.yml?

@bertysentry - oh my, I had assumed that that had been added, yes that will probably be what is causing problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n internationalization lang:fr upstream
Projects
Status: No status
Development

No branches or pull requests

2 participants