Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5826: Create observability-primer.md (French version) #5833

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

iguitton
Copy link
Contributor

Translated the observability-primer.md into French

@iguitton iguitton requested a review from a team as a code owner December 20, 2024 14:45
@opentelemetrybot opentelemetrybot requested review from a team December 20, 2024 14:45
@iguitton
Copy link
Contributor Author

iguitton commented Dec 20, 2024

Hi @svrnm ,

As mentioned in the PR #5386 (comment), the spell checker is working fine, but it seems that the dictionary lacks many common French words. This is currently blocking the merge.
Adding the 152 missing words to the dictionary for this PR doesn't seem like a sustainable solution. Do you have any suggestions for addressing this issue more effectively?

Thanks,

Isa

@iguitton
Copy link
Contributor Author

iguitton commented Jan 2, 2025

@dmathieu, @codeboten, @marcalff, @theletterf, @cartermp, @austinlparker, @chalin and @svrnm: This PR is ready to be reviewed.

@bertysentry
Copy link
Contributor

Would it be okay if we imported the entire French dictionary into fr-mots.txt to avoid the cumbersome task of adding every single word in the French documentation manually?

@iguitton
Copy link
Contributor Author

iguitton commented Jan 3, 2025

Would it be okay if we imported the entire French dictionary into fr-mots.txt to avoid the cumbersome task of adding every single word in the French documentation manually?

@bertysentry , importing the entire French dictionary could address many issues, but we would still need to add words manually because the spell checker:

  • Is case-sensitive: It treats "Collecteur" and "collecteur" as distinct words.
  • Does not handle plural or gender variations: Singular and plural forms, as well as masculine and feminine versions, need to be added separately (e.g., "autre" and "autres"; "distribué", "distribuée", "distribués", and "distribuées").
  • Does not account for verb conjugations: All conjugated forms of verbs must be explicitly added to pass the spell checker test.
  • Does not recognize words with prefixes like "d'" or "l'": These are treated as new words, so both "autre" and "d'autre" need to be added to fr-mots.txt.

While importing a dictionary would reduce the workload, these limitations would still require manual intervention.

@chalin
Copy link
Contributor

chalin commented Jan 4, 2025

Adding the 152 missing words to the dictionary for this PR doesn't seem like a sustainable solution.

I agree that it isn't optimal nor sustainable.

Do you have any suggestions for addressing this issue more effectively?

Submitting PR(s) upstream to https://github.com/streetsidesoftware/cspell-dicts; for example, the last update seems to be streetsidesoftware/cspell-dicts#680. Any volunteers? It would be of benefit to all projects that use cSpell's fr_FR dictionaries.

I'm going to create a separate issue to track this... --> #5870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants