Add single writer principle note to deployment documentation #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetrybot
requested review from
atoulme
and removed request for
a team
tiffany76
reviewed
Sep 9, 2024
|
Hi @michael2893. Thanks for sticking with this. A couple of the Collector maintainers reviewed the earlier PR (#4433), so I'm going to ask them to take a look here and make sure their comments have been addressed. @jpkrohling, @mx-psi, PTAL. Thanks! |
|
@open-telemetry/collector-approvers PTAL! |
|
@open-telemetry/collector-approvers PTAL! |
jpkrohling
reviewed
Jan 2, 2025
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
tiffany76
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
I'm approving so we can get this merged. @michael2893, it looks like there's a conflict. Let us know if you need help resolving it.
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12644777977 |
|
IMPORTANT: (RE-)RUN
|
|
Merging! Thanks for the patience @michael2893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change addresses the request for documentation on the Single-Writer principle. #4368
Description
deployment/gateway