Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFORMANT_SIGNATURE & INFORMANT_SIGNATURE_REQUIRED are now deprecated… #8287

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −37
Open

INFORMANT_SIGNATURE & INFORMANT_SIGNATURE_REQUIRED are now deprecated… #8287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@

## 1.6.2 Release candidate

### Deprecated

- `INFORMANT_SIGNATURE` & `INFORMANT_SIGNATURE_REQUIRED` are now deprecated and part of form config

### Bug fixes

- Fix health facilities missing from dropdown after correcting a record address [#7528](https://github.com/opencrvs/opencrvs-core/issues/7528)
Expand Down
1 change: 0 additions & 1 deletion packages/client/src/setupTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ const config = {
DEATH_REGISTRATION: true,
MARRIAGE_REGISTRATION: true,
EXTERNAL_VALIDATION_WORKQUEUE: false,
INFORMANT_SIGNATURE: true,
PRINT_DECLARATION: true
},
LANGUAGES: 'en,bn,fr',
Expand Down
4 changes: 1 addition & 3 deletions packages/client/src/tests/mock-offline-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,8 @@ export const mockOfflineData = {
DEATH_REGISTRATION: true,
MARRIAGE_REGISTRATION: true,
EXTERNAL_VALIDATION_WORKQUEUE: true,
INFORMANT_SIGNATURE: false,
PRINT_DECLARATION: true,
DATE_OF_BIRTH_UNKNOWN: true,
INFORMANT_SIGNATURE_REQUIRED: false
DATE_OF_BIRTH_UNKNOWN: true
},
HEALTH_FACILITY_FILTER: 'DISTRICT',
LANGUAGES: 'en,bn',
Expand Down
4 changes: 0 additions & 4 deletions packages/client/src/tests/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,6 @@ type ApplicationConfiguration {
EXTERNAL_VALIDATION_WORKQUEUE: Boolean
PHONE_NUMBER_PATTERN: String
NID_NUMBER_PATTERN: String
INFORMANT_SIGNATURE: Boolean
INFORMANT_SIGNATURE_REQUIRED: Boolean
USER_NOTIFICATION_DELIVERY_METHOD: String
INFORMANT_NOTIFICATION_DELIVERY_METHOD: String
DATE_OF_BIRTH_UNKNOWN: Boolean
Expand All @@ -222,8 +220,6 @@ input ApplicationConfigurationInput {
EXTERNAL_VALIDATION_WORKQUEUE: Boolean
PHONE_NUMBER_PATTERN: String
NID_NUMBER_PATTERN: String
INFORMANT_SIGNATURE: Boolean
INFORMANT_SIGNATURE_REQUIRED: Boolean
USER_NOTIFICATION_DELIVERY_METHOD: String
INFORMANT_NOTIFICATION_DELIVERY_METHOD: String
DATE_OF_BIRTH_UNKNOWN: Boolean
Expand Down
20 changes: 0 additions & 20 deletions packages/client/src/utils/gateway-deprecated-do-not-use.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,8 +722,6 @@ export interface GQLApplicationConfiguration {
EXTERNAL_VALIDATION_WORKQUEUE?: boolean
PHONE_NUMBER_PATTERN?: string
NID_NUMBER_PATTERN?: string
INFORMANT_SIGNATURE?: boolean
INFORMANT_SIGNATURE_REQUIRED?: boolean
USER_NOTIFICATION_DELIVERY_METHOD?: string
INFORMANT_NOTIFICATION_DELIVERY_METHOD?: string
DATE_OF_BIRTH_UNKNOWN?: boolean
Expand All @@ -741,8 +739,6 @@ export interface GQLApplicationConfigurationInput {
EXTERNAL_VALIDATION_WORKQUEUE?: boolean
PHONE_NUMBER_PATTERN?: string
NID_NUMBER_PATTERN?: string
INFORMANT_SIGNATURE?: boolean
INFORMANT_SIGNATURE_REQUIRED?: boolean
USER_NOTIFICATION_DELIVERY_METHOD?: string
INFORMANT_NOTIFICATION_DELIVERY_METHOD?: string
DATE_OF_BIRTH_UNKNOWN?: boolean
Expand Down Expand Up @@ -5184,8 +5180,6 @@ export interface GQLApplicationConfigurationTypeResolver<TParent = any> {
EXTERNAL_VALIDATION_WORKQUEUE?: ApplicationConfigurationToEXTERNAL_VALIDATION_WORKQUEUEResolver<TParent>
PHONE_NUMBER_PATTERN?: ApplicationConfigurationToPHONE_NUMBER_PATTERNResolver<TParent>
NID_NUMBER_PATTERN?: ApplicationConfigurationToNID_NUMBER_PATTERNResolver<TParent>
INFORMANT_SIGNATURE?: ApplicationConfigurationToINFORMANT_SIGNATUREResolver<TParent>
INFORMANT_SIGNATURE_REQUIRED?: ApplicationConfigurationToINFORMANT_SIGNATURE_REQUIREDResolver<TParent>
USER_NOTIFICATION_DELIVERY_METHOD?: ApplicationConfigurationToUSER_NOTIFICATION_DELIVERY_METHODResolver<TParent>
INFORMANT_NOTIFICATION_DELIVERY_METHOD?: ApplicationConfigurationToINFORMANT_NOTIFICATION_DELIVERY_METHODResolver<TParent>
DATE_OF_BIRTH_UNKNOWN?: ApplicationConfigurationToDATE_OF_BIRTH_UNKNOWNResolver<TParent>
Expand Down Expand Up @@ -5269,20 +5263,6 @@ export interface ApplicationConfigurationToNID_NUMBER_PATTERNResolver<
(parent: TParent, args: {}, context: any, info: GraphQLResolveInfo): TResult
}

export interface ApplicationConfigurationToINFORMANT_SIGNATUREResolver<
TParent = any,
TResult = any
> {
(parent: TParent, args: {}, context: any, info: GraphQLResolveInfo): TResult
}

export interface ApplicationConfigurationToINFORMANT_SIGNATURE_REQUIREDResolver<
TParent = any,
TResult = any
> {
(parent: TParent, args: {}, context: any, info: GraphQLResolveInfo): TResult
}

export interface ApplicationConfigurationToUSER_NOTIFICATION_DELIVERY_METHODResolver<
TParent = any,
TResult = any
Expand Down
2 changes: 0 additions & 2 deletions packages/client/src/utils/referenceApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,8 @@ export interface IApplicationConfig {
DEATH_REGISTRATION: boolean
MARRIAGE_REGISTRATION: boolean
EXTERNAL_VALIDATION_WORKQUEUE: boolean
INFORMANT_SIGNATURE: boolean
PRINT_DECLARATION: boolean
DATE_OF_BIRTH_UNKNOWN: boolean
INFORMANT_SIGNATURE_REQUIRED: boolean
}
FIELD_AGENT_AUDIT_LOCATIONS: string
DECLARATION_AUDIT_LOCATIONS: string
Expand Down
2 changes: 0 additions & 2 deletions packages/client/typings/window.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,9 @@ interface Window {
FEATURES: {
DEATH_REGISTRATION: boolean
MARRIAGE_REGISTRATION: boolean
INFORMANT_SIGNATURE: boolean
EXTERNAL_VALIDATION_WORKQUEUE: boolean
PRINT_DECLARATION: boolean
DATE_OF_BIRTH_UNKNOWN: boolean
INFORMANT_SIGNATURE_REQUIRED: boolean
}
LANGUAGES: string
LOGIN_URL: string
Expand Down
2 changes: 0 additions & 2 deletions packages/config/src/handlers/application/applicationConfigHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ const mockConfig = {
},
MARRIAGE_REGISTRATION: false,
DATE_OF_BIRTH_UNKNOWN: false,
INFORMANT_SIGNATURE: true,
INFORMANT_SIGNATURE_REQUIRED: true,
HEALTH_FACILITY_FILTER: 'UPAZILA',
LOGIN_URL: 'http://localhost:3020',
AUTH_URL: 'http://localhost:4040',
Expand Down
4 changes: 1 addition & 3 deletions packages/config/src/handlers/application/applicationConfigHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,8 @@ const applicationConfigResponseValidation = Joi.object({
DEATH_REGISTRATION: Joi.boolean().required(),
MARRIAGE_REGISTRATION: Joi.boolean().required(),
EXTERNAL_VALIDATION_WORKQUEUE: Joi.boolean().required(),
INFORMANT_SIGNATURE: Joi.boolean().required(),
PRINT_DECLARATION: Joi.boolean().required(),
DATE_OF_BIRTH_UNKNOWN: Joi.boolean().required(),
INFORMANT_SIGNATURE_REQUIRED: Joi.boolean().required()
DATE_OF_BIRTH_UNKNOWN: Joi.boolean().required()
},
USER_NOTIFICATION_DELIVERY_METHOD: Joi.string().allow('').optional(),
INFORMANT_NOTIFICATION_DELIVERY_METHOD: Joi.string().allow('').optional(),
Expand Down
Loading