Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream main #456

Merged
merged 33 commits into from
Dec 20, 2024

Conversation

hdefazio
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

LOADBC and others added 30 commits November 7, 2024 09:02
…rve#4012)

* Fix readiness probe logic and update test scenarios for HTTPGet, TCPSocket, and Exec handling

Signed-off-by: Snehomoy <snehomoy6@gmail.com>

* Update: Refactor logic for readiness probe handling

Signed-off-by: Snehomoy <snehomoy6@gmail.com>

* Apply gofmt formatting to agent_injector.go

Signed-off-by: Snehomoy <snehomoy6@gmail.com>

* Added logger to replace fmt.Printf for better consistency and observability

Signed-off-by: Snehomoy <snehomoy6@gmail.com>

* Formatted file using goimports with -local

Signed-off-by: Snehomoy <snehomoy6@gmail.com>

---------

Signed-off-by: Snehomoy <snehomoy6@gmail.com>
) (kserve#4018)

* Feat: Fix memory issue by replacing io.ReadAll with io.Copy (kserve#4017)

Previously, io.ReadAll was causing out-of-memory problems when downloading large files from GCS.
This change replaces io.ReadAll() with io.Copy() to stream data and prevent excessive memory usage.

Signed-off-by: ops-jaeha <me@jaehai.com>

* Feat: Fix add newline at end of file to satisfy golang lint

Signed-off-by: ops-jaeha <me@jaehai.com>

* Feat: Refact log Info for golang lint (kserve#4017)

Signed-off-by: ops-jaeha <me@jaehai.com>

---------

Signed-off-by: ops-jaeha <me@jaehai.com>
chore:	Fix CVE-2024-26130 - NULL Pointer Dereference
	  - Upgrade cryptography to version 42.0.4 or higher.
	Update Python version to match KServe 0.14.0
	Update tensorflow, tensorflow-io-gcs-filesystem and dill libraries

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Kursat Aktas <kursat.ce@gmail.com>
…rve#4024)

* Fix huggingface srever not work with return_probabilities

Signed-off-by: oplushappy <ken910304@gmail.com>

* Fix pytest huggingface server assertion error

Signed-off-by: oplushappy <ken910304@gmail.com>

* Fix the lint error and Add approx for  assertion

Signed-off-by: oplushappy <ken910304@gmail.com>

* Parse string output to dictionary for accurate assertion

Signed-off-by: oplushappy <ken910304@gmail.com>

* Fix linting error

Signed-off-by: oplushappy <ken910304@gmail.com>

---------

Signed-off-by: oplushappy <ken910304@gmail.com>
* Add deeper readiness and liveness check for transformer

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add unit tests

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* put the feature behind flag

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update tests

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* resolve comments

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Make use of inference client

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add e2e test

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Make inference client singleton and lazy initialize

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Raise 503 If server is not ready / live

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add test for custom transformer with rest protocol

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix CI running out of space

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Increase memory limit

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Check for model ready

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Webhook debug

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Address reviews

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Check for retry count in grpc client

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update python/kserve/kserve/model_server.py

Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
remove duplicated import

Signed-off-by: carlory <baofa.fan@daocloud.io>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* add storageaccesskey to azure env builder

Signed-off-by: bentohset <toh.benjamin123@gmail.com>

* update integration and unit test for azure storage access key

Signed-off-by: bentohset <toh.benjamin123@gmail.com>

* fix formatting

Signed-off-by: bentohset <toh.benjamin123@gmail.com>

---------

Signed-off-by: bentohset <toh.benjamin123@gmail.com>
* support single digit azure zone id

Signed-off-by: bentohset <toh.benjamin123@gmail.com>

* add single digit azure dns zone id tests

Signed-off-by: bentohset <toh.benjamin123@gmail.com>

* fix formatting

Signed-off-by: bentohset <toh.benjamin123@gmail.com>

---------

Signed-off-by: bentohset <toh.benjamin123@gmail.com>
* Fix trust_remote_code not passed in encoder model

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add test

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix name conflict in e2e test

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
* introduce the prepare-for-release.sh script

chore:	The purpose of this script is to facilitate the
	release process by updating the KServe version
	everywhere that is necessary.

fixes kserve#3399

Signed-off-by: Spolti <fspolti@redhat.com>

* review - update release_process_v2.md

Signed-off-by: Spolti <fspolti@redhat.com>

* Update hack/prepare-for-release.sh

Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Filippe Spolti <filippespolti@gmail.com>

* Update hack/prepare-for-release.sh

Signed-off-by: Filippe Spolti <filippespolti@gmail.com>

* Update hack/prepare-for-release.sh

Signed-off-by: Filippe Spolti <filippespolti@gmail.com>

---------

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Filippe Spolti <filippespolti@gmail.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
* LocalModelNode Daemonset Controller Skeleton (kserve#4026)

* hello world controller

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* go fmt

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* daemonset

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* Update Makefile

Co-authored-by: Jin Dong <greenmoon55@users.noreply.github.com>
Signed-off-by: Gavin Li <yueqi.li.usa@gmail.com>

* make generate

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* install LocalModelNode CRD

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* feedback

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* make manifests

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* agent

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

Co-authored-by: Jin Dong <greenmoon55@users.noreply.github.com>

* LocalModelController creates LocalModelNode resource for ready nodes (kserve#4036)

* Manage localmodelNode

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update patch

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Fix rbac

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Add a test to controller_test.go

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update pkg/controller/v1alpha1/localmodel/controller.go

Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

---------

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* Delete from LocalModelNode when the localmodel is deleted (kserve#4053)

* Delete model from LocalModelNode

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Cleanup code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Cleanup code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Fix lint

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Initializer node status map

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Address comments

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

---------

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update Model status from LocalModelNode status (kserve#4056)

* Delete model from LocalModelNode

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Cleanup code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Cleanup code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Fix lint

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Initializer node status map

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update status

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update localmodel node status

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Remove job dependency from localmodel controller

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Remove some unused lines

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Add comments

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

---------

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* LocalModelNode Agent that creates download jobs and update statuses from jobs (kserve#4075)

* download working

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* delete working

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* cleanup

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* gofmt

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* Delete model from LocalModelNode

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Cleanup code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Fix lint

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Initializer node status map

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update status

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update localmodel node status

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Remove job dependency from localmodel controller

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Remove some unused lines

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Add comments

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update manager

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update rbac

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Add tests and temporarily remove delete models code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Do not create download jobs if model is already downloaded

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* remove mislieading log line

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Clean up code a little bit

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update configurations

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* update test

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Use a fixed name for the download container

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

---------

Signed-off-by: Gavin Li <yli1109@bloomberg.net>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Co-authored-by: Gavin Li <yli1109@bloomberg.net>

* Delete models from local disk when they are not in LocalModelNode spec (kserve#4084)

* download working

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* delete working

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* Delete model from LocalModelNode

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Initializer node status map

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update status

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update localmodel node status

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update manager

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update rbac

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Add tests and temporarily remove delete models code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Do not create download jobs if model is already downloaded

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Delete function

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Update configurations

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Add test and Fix deletion code

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Use a fixed name for the download container

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Remove deleted models from status and periodically trigger reconciliation

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

* Fix storagecontainer permissions and a minor change

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>

---------

Signed-off-by: Gavin Li <yli1109@bloomberg.net>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Co-authored-by: Gavin Li <yli1109@bloomberg.net>

---------

Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Signed-off-by: Gavin Li <yli1109@bloomberg.net>
Co-authored-by: Gavin Li <yli1109@bloomberg.net>
Co-authored-by: Jin Dong <greenmoon55@users.noreply.github.com>
storage containers typo fix

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Support datetime object in v1/v2 response

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* Update ClusterLocalModel to LocalModelCache

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix generation fmt

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* black fmt

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix generated code

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Run go mod tidy

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix model status

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
* Fix LocalModel controller reconciles deleted resource

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Rebase

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix path base routing e2e workflow

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
…erve#4003)

* Requeue and then double check the Pending status

Signed-off-by: Hannah DeFazio <h2defazio@gmail.com>

* Add test case, fix old tests

Signed-off-by: Hannah DeFazio <h2defazio@gmail.com>

* Check the retun value for PropagateModelStatus, add knative failure case

Signed-off-by: Hannah DeFazio <h2defazio@gmail.com>

---------

Signed-off-by: Hannah DeFazio <h2defazio@gmail.com>
Co-authored-by: Hannah DeFazio <hdefazio@hdefazio-thinkpadp16vgen1.rht.csb>
* init

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* broken code

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* register webhook

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* rename + working

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* pass in client

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

* check storageURI

Signed-off-by: Gavin Li <yli1109@bloomberg.net>

---------

Signed-off-by: Gavin Li <yli1109@bloomberg.net>
…art (kserve#4111)

add localmodelnode agent image

Signed-off-by: Rituraj Singh <rsingh660@bloomberg.net>
Co-authored-by: Rituraj Singh <rsingh660@bloomberg.net>
* added vllm cpu image dockerfile

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* updated predictor controller to add '-gpu' suffix to huggingfaceserver image tag for GPU deployments

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* cleanup

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* added unit testcase for UpdateImageTag util

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* added documentation for vLLM CPU support

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* updated vllm-cpu example with llama 3.1 model

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* modified dockerfile to use vllm requirements-build to install dependencies

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* shifted to use vLLM with OpenVINO for CPU workloads

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* upgraded vllm and torch versions for huggingfaceserver

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* change base image to ubuntu

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* addressed comments in dockerfile and github workflow

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* added e2e test case

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* added huggingface_server_cpu_openvino image build in CI

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* updated poetry version

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* done linting

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* ran poetry lock --no-update

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* ran black formatting

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* removed huggingface server gpu image build in e2e tests

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* made separate job for e2e test of huggingface server vllm backend

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* updated vllm completion response in test

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* added vllm marker in pytest.ini file

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* reverted to vLLM v0.6.3.post1

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* added vllm-openvino limitations in documentation

Signed-off-by: ayush <ayush.sawant@nutanix.com>

* updated poetry lock

Signed-off-by: ayush <ayush.sawant@nutanix.com>

---------

Signed-off-by: ayush <ayush.sawant@nutanix.com>
Signed-off-by: Ayush Sawant <ayush.sawant@nutanix.com>
Signed-off-by: datta0 <datta.nimmaturi@nutanix.com>
* chore: use patch instead of update for finalizer changes

Signed-off-by: Derek Wang <whynowy@gmail.com>

* go mod tidy

Signed-off-by: Derek Wang <whynowy@gmail.com>

* lint

Signed-off-by: Derek Wang <whynowy@gmail.com>

---------

Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
* Fix localmodelcache permission for isvc

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Patch localmodelcache webhook for kubeflow overlay

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
@hdefazio
Copy link
Author

/rerun-all

@hdefazio
Copy link
Author

hdefazio commented Dec 19, 2024

test

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Copy link

openshift-ci bot commented Dec 19, 2024

@hdefazio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-fast 9469f1f link true /test e2e-fast
ci/prow/e2e-slow 9469f1f link true /test e2e-slow
ci/prow/e2e-raw 9469f1f link true /test e2e-raw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hdefazio hdefazio requested a review from israel-hdez December 19, 2024 17:50
Copy link

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hdefazio, israel-hdez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hdefazio,israel-hdez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez israel-hdez merged commit 4b2f139 into opendatahub-io:master Dec 20, 2024
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.