remove process.env.NODE_ENV warning

[dario-piotrowicz]

A quick (hopefully temporary) solution for the process.env.NODE_ENV warning:

[changeset-bot]

🦋 Changeset detected

Latest commit: b5b7994

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@opennextjs/cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@211

commit: b5b7994

[vicb]

It looks like the right (safe) thing to do but because this is Open Next code, it would be easier to modify the code at https://github.com/opennextjs/opennextjs-aws/blob/9595714ac23e5f131b879d04d5cfb2a5d11bdbdd/packages/open-next/src/adapters/util.ts#L4

[dario-piotrowicz]

It looks like the right (safe) thing to do but because this is Open Next code, it would be easier to modify the code at https://github.com/opennextjs/opennextjs-aws/blob/9595714ac23e5f131b879d04d5cfb2a5d11bdbdd/packages/open-next/src/adapters/util.ts#L4

yes I agree, but I am not sure how to discern there if the code is being used by Cloudflare and also I wouldn't want to overcomplicate things there only for our use case, I think that it's probably something worth tackling/looking into when we move to a shared monorepo setup, right now I would just add this quick patch to remove the warning not to annoy/scare users away

but I agree that ideally it should be solved in a better way, I just don't think that it's a high enough priority right for us to tackle in such a way right now

if you disagree with the patch I am totally fine not including it 👍

[vicb]

Yes the line I pointed to is the one causing the warning.

It is better to make the function 2 lines there to avoid adding a patch that we would migrate to AST later.