-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vercel blog starter to examples #86
Conversation
🦋 Changeset detectedLatest commit: deccf66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
One thing you can do is two separate commit:
It's nice to have the required changes in the history |
commit: |
ab5f1f7
to
2d48c79
Compare
2d48c79
to
c63b16a
Compare
Made all the recommended changes and had the commits in the flow, that is nice to read |
a29ecac
to
15faac1
Compare
I had to delete the commit where I remove Maybe if you want, I can investigate it as a separate issue |
My bad, it should not be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you so much!
2 things:
- could you please add a patch changeset
- it would be nice to add a basic e2e test, you can check i.e. the API example. If you are willing to do this, you can do it in a follow up PR when you have time. No rush.
@vicb I have added the changeset. In regards to adding an e2e test, I will do it in another PR as I don't want to keep holding this one :) |
Created using `pnpm create next-app --example blog-starter vercel-blog-starter`
using pnpm `pnpm run code:fixes`
33211ee
to
deccf66
Compare
Yep, makes sense. Thank for adding the example! |
Added the vercel blog starter to examples as a way to test applications. I used this from vercel which wasn't working but fixed it to the needs of the adapter
You can run the new example using
pnpm --filter vercel-blog-starter preview:worker