-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse token filter docs #8274 #8395
Add reverse token filter docs #8274 #8395
Conversation
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
@udabhas Will you review this PR for technical accuracy, or have a peer review it? Thank you. |
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws Several comments and changes. Thanks!
_analyzers/token-filters/reverse.md
Outdated
- **Suffix matching**: Searching for words based on their endings, like identifying words that end with specific patterns (for example, `-tion` or `-ing`). | ||
- **File extension searches**: Searching for files by their extensions, such as `.txt` or `.jpg`. | ||
- **Custom sorting or ranking**: By reversing tokens, you can implement unique sorting or ranking logic based on suffixes. | ||
- **Autocomplete for suffixes**: Implementing autocomplete suggestions that focus on suffixes rather than prefixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"focus on" (too ambiguous) => "use" or "provide"?
- **Autocomplete for suffixes**: Implementing autocomplete suggestions that focus on suffixes rather than prefixes. | ||
|
||
The `reverse` token filter works by reversing the order of characters in each token, making suffix information accessible at the start of the reversed tokens during analysis. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 21 is a duplicate of line 10.
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
* adding reverse token filter docs #8274 Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> * Doc review Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Fanit Kolchina <kolchfa@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 7bcd36c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add reverse token filter docs
Issues Resolved
Closes #8274
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.