-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation on innerHits of nested k-NN field #8822
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Heemin Kim <heemin@amazon.com>
@kolchfa-aws any update? |
Hi @heemin32, could you please tag me when ready for review next time? I will review this PR tomorrow. Thanks! |
Will do. Thanks! |
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@heemin32 Doc review complete. Could you look over the PR and let me know if anything should be changed? Thanks! |
@kolchfa-aws LGTM. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heemin32 @kolchfa-aws LGTM!
Description
Updated documentation on innerHits of nested k-NN field
Issues Resolved
Closes #8819
Version
2.19
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.