Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation on innerHits of nested k-NN field #8822

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

heemin32
Copy link
Contributor

Description

Updated documentation on innerHits of nested k-NN field

Issues Resolved

Closes #8819

Version

2.19

Frontend features

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@heemin32 heemin32 marked this pull request as draft November 27, 2024 19:37
Signed-off-by: Heemin Kim <heemin@amazon.com>
@heemin32 heemin32 marked this pull request as ready for review December 11, 2024 22:07
@heemin32
Copy link
Contributor Author

@kolchfa-aws any update?

@kolchfa-aws
Copy link
Collaborator

Hi @heemin32, could you please tag me when ready for review next time? I will review this PR tomorrow. Thanks!

@kolchfa-aws kolchfa-aws added release-notes PR: Include this PR in the automated release notes v2.19.0 labels Dec 17, 2024
@heemin32
Copy link
Contributor Author

Hi @heemin32, could you please tag me when ready for review next time? I will review this PR tomorrow. Thanks!

Will do. Thanks!

kolchfa-aws and others added 2 commits December 17, 2024 09:02
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@kolchfa-aws
Copy link
Collaborator

@heemin32 Doc review complete. Could you look over the PR and let me know if anything should be changed? Thanks!

@heemin32
Copy link
Contributor Author

@kolchfa-aws LGTM. Thanks!

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws kolchfa-aws merged commit f3eb6f7 into opensearch-project:main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC]Multi innerhit in nested k-NN field
3 participants