Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the issue that the access_token expired and could not be refreshed #18

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

Fleurxxx
Copy link
Contributor

@Fleurxxx Fleurxxx commented Jul 8, 2024

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features
    • Enhanced AI chat functionality by adding support for accessToken, allowing for more personalized and secure interactions.
  • Documentation
    • Updated documentation comments for the AI chat methods to improve clarity and understanding.

Copy link

coderabbitai bot commented Jul 8, 2024

Walkthrough

The recent updates enhance the AI chat functionality by introducing an accessToken parameter, affecting the AiChatController, AiChat service methods, and the AI chat configuration. This integration allows for more secure and personalized interactions, improving API calls and authentication throughout the chat process.

Changes

Files Change Summaries
.../controller/app-center/aiChat.ts Enhanced aiChat() method to include accessToken in the request body.
.../service/app-center/aiChat.ts Updated service methods to accept and utilize accessToken for enhanced functionality.
config/config.default.ts Modified config.aiChat function to require accessToken for improved configuration handling.

Poem

In our code, a token shines,
Enhancing AI chat's designs.
Through your models, swift and true,
Access granted, thanks to you.
So chat away, with confidence high,
Secured dialogue, make us fly! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aab88ea and 1665c01.

Files selected for processing (3)
  • app/controller/app-center/aiChat.ts (1 hunks)
  • app/service/app-center/aiChat.ts (2 hunks)
  • config/config.default.ts (2 hunks)
Additional comments not posted (7)
app/controller/app-center/aiChat.ts (2)

25-25: Approved: Added accessToken to request body.

The addition of the accessToken parameter in the request body is correct and ensures proper authentication.


31-31: Approved: Passing accessToken to service layer.

The accessToken is correctly passed to the getAnswerFromAi method, ensuring it is utilized in the service layer.

app/service/app-center/aiChat.ts (3)

33-33: Approved: Added accessToken parameter.

The addition of the accessToken parameter in the getAnswerFromAi method is correct and ensures proper authentication.


48-48: Approved: Added accessToken parameter.

The addition of the accessToken parameter in the requestAnswerFromAi method is correct and ensures proper authentication.


54-54: Approved: Using accessToken in AI chat configuration.

The accessToken is correctly used in the AI chat configuration, ensuring proper authentication.

config/config.default.ts (2)

250-250: Approved: Added accessToken parameter.

The addition of the accessToken parameter in the config.aiChat function is correct and ensures proper authentication.


282-282: Approved: Using accessToken in ERNIE_BOT_TURBO configuration.

The accessToken is correctly used in the configuration for the ERNIE_BOT_TURBO model, ensuring proper authentication.

@Fleurxxx Fleurxxx changed the title fix: 修复文心一言模型access_token过期不能刷新问题 fix: Fixed the issue that the access_token expired and could not be refreshed Jul 10, 2024
@CatsAndMice
Copy link

@Lu17301156525 这个PR需要维护者审批才能合并过去

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@Lu17301156525 This PR requires the maintainer’s approval before it can be merged.

config/config.default.ts Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1665c01 and e305ec2.

Files selected for processing (3)
  • app/controller/app-center/aiChat.ts (2 hunks)
  • app/service/app-center/aiChat.ts (6 hunks)
  • config/config.default.ts (3 hunks)
Additional comments not posted (4)
app/controller/app-center/aiChat.ts (1)

31-32: Ensure proper handling of the token parameter.

The token parameter is correctly extracted from foundationModel and passed to the getAnswerFromAi service call. Ensure that the token is always available and properly validated before use.

app/service/app-center/aiChat.ts (2)

43-43: Ensure proper handling of the token parameter.

The token parameter is correctly passed to the requestAnswerFromAi method. Ensure that the token is always available and properly validated before use.


53-53: Ensure proper handling of the token parameter.

The token parameter is correctly used to retrieve the AI chat configuration. Ensure that the token is always available and properly validated before use.

config/config.default.ts (1)

249-290: Ensure proper handling of the accessToken parameter.

The accessToken parameter is correctly used to construct the configuration for different AI models. Ensure that the accessToken is always available and properly validated before use.

@Fleurxxx Fleurxxx force-pushed the ospp-2024/004-ai-multimodal branch from e305ec2 to 023f461 Compare July 30, 2024 17:56
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e305ec2 and 023f461.

Files selected for processing (3)
  • app/controller/app-center/aiChat.ts (2 hunks)
  • app/service/app-center/aiChat.ts (6 hunks)
  • config/config.default.ts (3 hunks)
Files skipped from review as they are similar to previous changes (3)
  • app/controller/app-center/aiChat.ts
  • app/service/app-center/aiChat.ts
  • config/config.default.ts

@Fleurxxx Fleurxxx force-pushed the ospp-2024/004-ai-multimodal branch from 023f461 to 0d31035 Compare July 30, 2024 18:24
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 023f461 and 0d31035.

Files selected for processing (3)
  • app/controller/app-center/aiChat.ts (2 hunks)
  • app/service/app-center/aiChat.ts (6 hunks)
  • config/config.default.ts (3 hunks)
Files skipped from review as they are similar to previous changes (3)
  • app/controller/app-center/aiChat.ts
  • app/service/app-center/aiChat.ts
  • config/config.default.ts

@CatsAndMice
Copy link

@Lu17301156525 麻烦合并下这个PR

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@Lu17301156525 Please merge this PR

@wenmine wenmine merged commit f63224f into opentiny:main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants