Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add generation time metrics #613
add generation time metrics #613
Changes from 9 commits
cb100cb
f0e4190
7cab496
bb1113c
0a8f0d9
90320f4
aeec730
c45aed5
be2fdaf
b00bcd8
60e7188
e553ef5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an extended greedy sample. One option is to merge it with chat_sample because it already has a loop over prompts. Is there a reason to have it as a separate sample?
Please, add tests: for the samples and functional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just thought that greedy sample should be easy as possible and do not compilate it with other argument and outputs such as number of warmups, and so on.
Communicated personally. Main takeaways.
We already have a separate sample for each case, e.g. multinomial decoding despite the fact it differ just by generate params. Probably instead of adding more samples we should add features to the existing ones.
But still, benchmark_genai also allows benchmarking with multibatch inputs while chat has only batch 1. Therefore we decided to keep as a separate sample, at least in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it gets merged, please, open another PR adding it to C++ and Python docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done #713