-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check PageAttention #704
Closed
wgzintel
wants to merge
27
commits into
openvinotoolkit:master
from
wgzintel:guozhong/check_model_pattern_changes
Closed
Check PageAttention #704
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e7e121e
check model pattern changes
wgzintel ed5369d
clone tests/model_hub_tests
wgzintel ab1fb17
PagedAttention Test
wgzintel e106c8d
Remove redundant commands
wgzintel 9767955
suppress warning summary
wgzintel ea218b1
Generate a new file to check model changes
wgzintel 95af9be
updated to latest of master
wgzintel 429cc1b
modify requirements.txt
wgzintel 45d7a9b
test triggering check model pattern changes
wgzintel bdc738b
test triggering check model pattern changes
wgzintel 4886e01
test triggering check model pattern changes
wgzintel a332959
revert requirements.txt
wgzintel 3653581
revert benchmark.py
wgzintel 6c8c361
modify check_model_pattern_changes.yml
wgzintel 7241335
modify requirement.txt
wgzintel 715eccc
modify check_model_pattern_changes.yml
wgzintel 7aa0c47
modify benchmark.py
wgzintel 2237c2b
revert benchmark.py
wgzintel 5c2a422
revert requirements.txt
wgzintel 3e12d31
resolve conflict
wgzintel 8d91eec
modify benchmark.py
wgzintel 518576d
revert benchmark.py
wgzintel 3007837
modify requirements.txt
wgzintel 1583514
revert requirements.txt
wgzintel 11f292b
Merge branch 'master' of https://github.com/openvinotoolkit/openvino.…
wgzintel 63c63e4
modify benchmark.py
wgzintel 2bcdc28
revert benchmark.py
wgzintel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# This workflow will install Python dependencies, run tests and lint with a single version of Python | ||
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python | ||
|
||
name: check model pattern changes | ||
|
||
env: | ||
LLM_BENCH_PYPATH: llm_bench/python | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- 'requirements.txt' | ||
- .github/workflows/check_model_pattern_changes.yml | ||
|
||
permissions: read-all # Required by https://github.com/ossf/scorecard/blob/e23b8ad91fd6a64a0a971ca4fc0a4d1650725615/docs/checks.md#token-permissions | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.9"] | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
python -m pip install pytest | ||
GIT_CLONE_PROTECTION_ACTIVE=false pip install -r ${{ env.LLM_BENCH_PYPATH }}/requirements.txt | ||
pip install openvino-nightly | ||
|
||
- name: PagedAttention Test | ||
run: | | ||
git clone --depth 1 --filter=blob:none --no-checkout https://github.com/openvinotoolkit/openvino | ||
cd openvino | ||
git checkout master tests/model_hub_tests/ | ||
cd tests/model_hub_tests | ||
python3 -m pytest transformation_tests/test_pa_transformation.py -m precommit -v --tb=short -Wignore | ||
env: | ||
TEST_DEVICE: CPU | ||
USE_SYSTEM_CACHE: False |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need such tests here? Looks like they can be run on OpenVINO side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilya-lavrenov The intention is to test when optimum-intel and transformers (or may be even NNCF?) changes.
We should think about the overlap with test
https://github.com/openvinotoolkit/openvino/blob/master/.github/workflows/job_pytorch_models_tests.yml