Produce a single archive #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out cpack ignores cache vars.
It turns out cpack ignores cache vars.
It turns out cpack ignores cache vars.
| @@ -64,7 +65,7 @@ add_subdirectory(tests/cpp) | |||
|
|
|||
| install(FILES LICENSE DESTINATION docs/licensing COMPONENT licensing_genai RENAME LICENSE-GENAI) | |||
| install(FILES third-party-programs.txt DESTINATION docs/licensing COMPONENT licensing_genai RENAME third-party-programs-genai.txt) | |||
| set(CPACK_ARCHIVE_COMPONENT_INSTALL ON) | |||
| set(CPACK_ARCHIVE_COMPONENT_INSTALL ${GENAI_CPACK_ARCHIVE_COMPONENT_INSTALL}) | |||
There was a problem hiding this comment.
maybe we can just use:
if(NOT DEFINED CPACK_ARCHIVE_COMPONENT_INSTALL )
set(CPACK_ARCHIVE_COMPONENT_INSTALL ON)
endif()
instead of extra option with different name
There was a problem hiding this comment.
I tried that as well. It doesn't work
There was a problem hiding this comment.
See openvinotoolkit/openvino#25867
We need the same fix for GenAI - tested locally against OV PR.
|
Suppressed by #726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out cpack ignores cache vars.