Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak: use a VM to build the package bundle #307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

claudioandre-br
Copy link
Member

Flatpak and snap don't work inside a Docker container. Gitlab runners are based on Docker (in our case).

So, it's unclear how long we'll be able to build using Gitlab. This PR prepares us to face this future.

For our future, farewell Gitlab.

Describe your changes

In order to be able to test the package, we need to build the image outside of a Docker container. Both snap and flatpak cannot run correctly inside a Docker container.

So, stop using Gitlab to build the flatpak bundle.

@claudioandre-br claudioandre-br added the help wanted Extra attention is needed label Apr 8, 2024
@claudioandre-br claudioandre-br force-pushed the flatpak branch 4 times, most recently from cfbdec2 to 58a296c Compare October 26, 2024 17:41
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed
deploy/flatpak/com.openwall.John.json Fixed Show fixed Hide fixed

This comment has been minimized.

@claudioandre-br claudioandre-br force-pushed the flatpak branch 3 times, most recently from 6ca51a1 to 27dba92 Compare October 26, 2024 20:49
@claudioandre-br
Copy link
Member Author

From actions run:

$ flatpak run com.openwall.John --list=opencl-devices
Error: No OpenCL-capable platforms were detected by the installed OpenCL driver.
Error: No OpenCL-capable devices were detected by the installed OpenCL driver.
$ flatpak run --command=clinfo com.openwall.John
Number of platforms                               0
ICD loader properties
  ICD loader Name                                 OpenCL ICD Loader
  ICD loader Vendor                               OCL Icd free software
  ICD loader Version                              2.3.2
  ICD loader Profile                              OpenCL 3.0

claudioandre-br added a commit that referenced this pull request Oct 31, 2024
In order to be able to test the package, we need to build the image
outside of a Docker container. Both snap and flatpak cannot run
correctly inside a Docker container.

So add a VM that allows us to create and test the flatpak bundle.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
claudioandre-br added a commit that referenced this pull request Nov 1, 2024
In order to be able to test the package, we need to build the image
outside of a Docker container. Both snap and flatpak cannot run
correctly inside a Docker container.

Our infrastructure at Gitlab is focused on Docker.
So add a VM that allows us to create and test the flatpak bundle.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
github-actions[bot]
github-actions bot previously approved these changes Nov 7, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved PR

claudioandre-br added a commit that referenced this pull request Nov 7, 2024
In order to be able to test the package, we need to build the image
outside of a Docker container. Both snap and flatpak cannot run
correctly inside a Docker container.

Our infrastructure at Gitlab is focused on Docker.
So add a VM that allows us to create and test the flatpak bundle.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
@claudioandre-br claudioandre-br added O: backlog Backlog (stale ignores this label) keep open Do NOT close automatically. and removed O: backlog Backlog (stale ignores this label) labels Nov 16, 2024
claudioandre-br added a commit that referenced this pull request Nov 17, 2024
In order to be able to test the package, we need to build the image
outside of a Docker container. Both snap and flatpak cannot run
correctly inside a Docker container.

Our infrastructure at Gitlab is focused on Docker.
So add a VM that allows us to create and test the flatpak bundle.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
In order to be able to test the package, we need to build the image
outside of a Docker container. Both snap and flatpak cannot run
correctly inside a Docker container.

Our infrastructure at Gitlab is focused on Docker.
So add a VM that allows us to create and test the flatpak bundle.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed keep open Do NOT close automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant