[openconnect] move interface changes from start/stop to vpnc script's hooks #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@fichtner Can we get a review on this please? This is a serious issue and causes me to have to manually ssh into the machine everytime this happens to fix it. |
|
@alexyao2015 did you test this PR on your end? it might help to getting this merged if someone else tested the change as well (we don't test these) |
|
@mimugmail needs to take a look, I also cannot verify this |
I'm actually using this solution on my router without troubles... every 8h the vpn drops and with a monit it automatically restart the connection with no errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes allow to change the interface names created from openconnect even if the connection was drop by server and not only by client. It uses standard hooks provided by vpnc-script.
It's related to this issue #4050