Add variable for default darkmode and default preview #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tefkah
changed the title
|
Hello, thanks for the pull request, I will try it when my exams are done and I have some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to solve #92, adds an option to set a variable called
org-roam-server-default-darkmode, which if set totwill always toggle darkmode when the server starts, regardless of cookies set.The second pull commit adds the option to set a variable called
org-roam-server-default-preview, which if set totwill enable preview by default, to solve #134.The latter does work a bit janky though, as it does not yet change the text or state of the preview button, but this is remedied when the
Enable Previewbutton is pressed once.Also they are two different AJAX calls and functions at the moment, ideally all these settings would only require a single one of course.
Apologies for the possibly somewhat sloppy code, I'm rather new to elisp.