Handle simplification panics #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biodranik
approved these changes
Sep 16, 2023
|
Looks like it's from stabilizing the formatting of let-else: https://blog.rust-lang.org/2023/07/01/rustfmt-supports-let-else-statements.html I've made a separate PR for it: #31 |
The caught html panics still print backtraces. Disabling it in rust would require changing the global panic handler when entering and exiting the function. Signed-off-by: Evan Lloyd New-Schmidt <evan@new-schmidt.com>
I've tested manually and it: - handles panics with a static message or formatted arguments - logs an error instead of exiting (backtraces are still printed) - writes any panic-causing html to an `errors/` subdirectory Signed-off-by: Evan Lloyd New-Schmidt <evan@new-schmidt.com>
newsch
force-pushed
the
simplify-panics
branch
from
eaee1d8 to
4ddb49c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested manually and it:
errors/subdirectory