-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean language #42
Conversation
aaa27bb
to
9bdfb1f
Compare
Signed-off-by: Lens0021 / Leslie <lorentz0021@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Did you test it?
@vng where else the language should be enabled?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Ok now I've tested this patch and the confirmed that the generated HTML files don't have the unwanted sections: How I've parsed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's see if it works without any additional changes in the generator code. Feel free to also add other wiki sections which are not necessary for a quick overview of the place.
@lens0021 thanks for the contribution and testing so thoroughly! |
At first, I didn't know how to run a maps build that was described at: Line 139 in 19d9f2c
So I tried the alternative way. But I didn't know what is pbf file. After reading https://wiki.openstreetmap.org/wiki/Planet.osm, I am still not sure there was the extract file for my country or not. Fortunately, I found it on the Google. Oh, and I could not expect that the config file was read in the build time. I thought the CLI read it. |
No description provided.