-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor remotes module #688
base: main
Are you sure you want to change the base?
Conversation
030ceae
to
d9745f6
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 36.89% 35.90% -0.99%
==========================================
Files 18 19 +1
Lines 1350 1382 +32
==========================================
- Hits 498 496 -2
- Misses 852 886 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey, thanks for your work on this! Should we mark as draft until #680 is merged (since this PR is based on those changes?) |
Okay. It still needs some documentation work done, since there is now a new URL config option to better support self-hosted instances. |
Thanks a lot for #680, it is merged now which means we can resume the work on this PR! |
ping @Theta-Dev |
Description
Refactoring of the
remotes
module to make the integration of new code forges easier.Motivation and Context
When I added Gitea integration (#680), I noticed a lot of redundant code blocks in the application which have to be copied for every code forge integration added. So I tried to rework the system to allow adding new remotes with minimal changes to the application.
Adding a new application now only consists of the following steps:
remote/<name>.rs
config.rs
and add it to the REMOTE_KINDS arrayThis obviously comes with breaking changes to the API of the
remote
module.How Has This Been Tested?
Screenshots / Logs (if applicable)
Types of Changes
Checklist: