-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use stable rustfmt #834
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 40.10% 40.15% +0.05%
==========================================
Files 21 21
Lines 1671 1684 +13
==========================================
+ Hits 670 676 +6
- Misses 1001 1008 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should probably cut a new point release just for these changes 💀 Do you know if there is a way of keeping the git blame while changing the formatting? I'm guessing it shouldn't be possible but it would be super nice if we can keep the historic footprint on the files somehow. |
Yes, it's possible:
Should I add the |
Wow perfect, please do it 👍🏼 |
Actually, I think we need to do this in another PR, after merging this so that we know the commit to ignore 👍 |
Can you push this again? There seems to be some conflicts.
I won't do a squash merge for this PR so it should be safe to use the commit hash :) |
5e05999
to
d8e22b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed all unstable options. Plus edition
is read from Cargo.toml
Ready for another look :) |
Description
close #618
Motivation and Context
How Has This Been Tested?
Screenshots / Logs (if applicable)
Types of Changes
Checklist: