Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add synergy between init and config flags #992

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xsadia
Copy link

@xsadia xsadia commented Dec 26, 2024

Description

Allow user to define init file by passing --config alongside to --init
closes #932

Motivation and Context

How Has This Been Tested?

Ran locally using --init and --config flags together as well as separate to make sure there where no breaking changes

Screenshots / Logs (if applicable)

image
image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xsadia xsadia requested a review from orhun as a code owner December 26, 2024 00:12
Copy link

welcome bot commented Dec 26, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 42.72%. Comparing base (e85888f) to head (c5be59d).

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   42.85%   42.72%   -0.13%     
==========================================
  Files          21       21              
  Lines        1734     1737       +3     
==========================================
- Hits          743      742       -1     
- Misses        991      995       +4     
Flag Coverage Δ
unit-tests 42.72% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could we init with config to pyproject.toml?
2 participants