fix(core): take output.indexFiles setting into account #1770
+110
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soartec-lab
requested changes
Dec 27, 2024
melloware
approved these changes
Dec 27, 2024
soartec-lab
reviewed
Dec 28, 2024
| @@ -132,3 +138,15 @@ export const writeSingleMode = async ({ | |||
| throw `Oups... 🍻. An Error occurred while writing file => ${e}`; | |||
| } | |||
| }; | |||
|
|
|||
| const generateImports = ( | |||
There was a problem hiding this comment.
This functionality is currently in split-tags, but should be common since it is used in all modes.
You can create a file like generate-imports-for-builder in the same directory.
There is already a function with the same name in utils, so I want to name the function generateImportsForBuilder to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes #1769
It appears only split-tags mode checked the
indexFilesflag, but not anymore!The linked PR below fixed this issue for mock imports for split-tags, but the change is necessary for all modes, both mock imports and regular imports.
Related PRs
List related PRs against other branches:
Todos