fix: hydra-maester.adminService.port empty value is passed into chi…

…ld chart, causes error. (#675)
ory · May 9, 2024 · d606ceb · d606ceb
1 parent 1c1702a
commit d606ceb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/helm/charts/hydra-maester/templates/deployment.yaml b/helm/charts/hydra-maester/templates/deployment.yaml
@@ -57,7 +57,7 @@ spec:
           args:
             - --metrics-addr=127.0.0.1:8080
             - --hydra-url={{ required "scheme is required" .Values.adminService.scheme }}://{{ .Values.adminService.name | default ( include "hydra-maester.adminService" . ) }}
-            - --hydra-port={{ .Values.adminService.port }}
+            - --hydra-port={{ required "port must be set and non-empty" .Values.adminService.port }}
             {{- with .Values.adminService.endpoint }}
             - --endpoint={{ . }}
             {{- end }}

diff --git a/helm/charts/hydra/values.yaml b/helm/charts/hydra/values.yaml
@@ -464,7 +464,7 @@ hydra-maester:
     # -- The service name value may need to be set if you use `fullnameOverride` for the parent chart
     name: ""
     # -- You only need to set this port if you change the value for `service.admin.port` in the parent chart
-    port:
+    # port:
 
 ## -- Sidecar watcher configuration
 watcher: