Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to run the same perltidy versions as downstream projects #45

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

perlpunk
Copy link
Collaborator

@perlpunk perlpunk commented Feb 6, 2024

By using our os-autoinst_dev container for running perltidy same as in e.g.
os-autoinst or openQA we are running the same perltidy version as in there.
This fixes the problem that a new release of Perl::Tidy on CPAN would bring in
a need to update to the new version whereas in downstream projects we are
relying on the version that is in openSUSE Tumbleweed and Leap.

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 6, 2024

https://github.com/os-autoinst/os-autoinst-common/actions/runs/7804753145/job/21287437215?pr=45#step:4:5

Can't locate Module/CPANfile.pm in @INC (you may need to install the Module::CPANfile module) (@INC entries checked: /usr/lib/perl5/site_perl/5.38.2/x86_64-linux-thread-multi /usr/lib/perl5/site_perl/5.38.2 /usr/lib/perl5/vendor_perl/5.38.2/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.38.2 /usr/lib/perl5/5.38.2/x86_64-linux-thread-multi /usr/lib/perl5/5.38.2 /usr/lib/perl5/site_perl) at ./tools/tidyall line 10.
5
BEGIN failed--compilation aborted at ./tools/tidyall line 10.

I will locally install it and see what else would be missing that we would need as new dependencies

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 6, 2024

Now I used registry.opensuse.org/devel/openqa/containers/openqa_dev:latest instead and get this:
https://github.com/os-autoinst/os-autoinst-common/actions/runs/7804800327/job/21287574180?pr=45#step:3:16

/usr/bin/docker exec  556531f4017638c5e00a9e211009123fe5f385b0b2e9e6c6211b8efd5a6187f1 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 6, 2024

Next try: registry.opensuse.org/devel/openqa/ci/containers/base:latest
https://github.com/os-autoinst/os-autoinst-common/actions/runs/7804856123/job/21287745676?pr=45#step:3:17

node:internal/fs/sync:78
  return binding.openSync(
                 ^

Error: EACCES: permission denied, open '/__w/_temp/_runner_file_commands/save_state_c3b0de20-17ba-4a5b-9938-44dde218e517'
    at Object.open (node:internal/fs/sync:78:18)
    at Object.openSync (node:fs:565:17)
    at Object.writeFileSync (node:fs:2288:35)
    at Object.appendFileSync (node:fs:2350:6)
    at Object.issueFileCommand (/__w/_actions/actions/checkout/v4/dist/index.js:2967:8)
    at Object.saveState (/__w/_actions/actions/checkout/v4/dist/index.js:2884:31)
    at 8647 (/__w/_actions/actions/checkout/v4/dist/index.js:2343:10)
    at __nccwpck_require__ (/__w/_actions/actions/checkout/v4/dist/index.js:18273:43)
    at 2565 (/__w/_actions/actions/checkout/v4/dist/index.js:146:34)
    at __nccwpck_require__ (/__w/_actions/actions/checkout/v4/dist/index.js:18273:43) {
  errno: -13,
  code: 'EACCES',
  syscall: 'open',
  path: '/__w/_temp/_runner_file_commands/save_state_c3b0de20-17ba-4a5b-9938-44dde218e517'
}```

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 6, 2024

Got the container running by downgrading the checkout to uses: actions/checkout@v1, but now:
https://github.com/os-autoinst/os-autoinst-common/actions/runs/7804938928/job/21287993158?pr=45#step:4:5

Can't locate Perl/Tidy.pm in @INC (you may need to install the Perl::Tidy module) (@INC contains: /usr/lib/perl5/site_perl/5.26.1/x86_64-linux-thread-multi /usr/lib/perl5/site_perl/5.26.1 /usr/lib/perl5/vendor_perl/5.26.1/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.26.1 /usr/lib/perl5/5.26.1/x86_64-linux-thread-multi /usr/lib/perl5/5.26.1 /usr/lib/perl5/site_perl) at ./tools/tidyall line 9.

So registry.opensuse.org/devel/openqa/ci/containers/base:latest doesn't have Perl::Tidy

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 6, 2024

I think since we need Module::CPANfile in os-autoinst as well in the future to be able to run tools/tidyall, we need it to add there as a dependency anyway. Preparing that now...

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 6, 2024

Waiting for:

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the git commit message I suggest that the subject line states the "Why", not the "What". How about

"Ensure to run the same perltidy versions as downstream projects"

And in the details you can still say
"By using our os-autoinst_dev container for running perltidy same as in e.g. os-autoinst or openQA we are running the same perltidy version as in there. This fixes the problem that a new release of Perl::Tidy on CPAN would bring in a need to update to the new version whereas in downstream projects we are relying on the version that is in openSUSE Tumbleweed and Leap."

By using our os-autoinst_dev container for running perltidy same as in e.g.
os-autoinst or openQA we are running the same perltidy version as in there.
This fixes the problem that a new release of Perl::Tidy on CPAN would bring in
a need to update to the new version whereas in downstream projects we are
relying on the version that is in openSUSE Tumbleweed and Leap.
@perlpunk perlpunk force-pushed the use-openqa-container branch from 8eed188 to a741e48 Compare February 7, 2024 10:39
@perlpunk perlpunk changed the title Use our os-autoinst_dev container for running perltidy Ensure to run the same perltidy versions as downstream projects Feb 7, 2024
@perlpunk perlpunk requested a review from okurz February 7, 2024 10:40
@mergify mergify bot merged commit e167bdf into os-autoinst:master Feb 7, 2024
6 checks passed
@perlpunk perlpunk deleted the use-openqa-container branch February 7, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants