-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure to run the same perltidy versions as downstream projects #45
Conversation
I will locally install it and see what else would be missing that we would need as new dependencies |
Now I used
|
Next try:
|
Got the container running by downgrading the checkout to
So registry.opensuse.org/devel/openqa/ci/containers/base:latest doesn't have Perl::Tidy |
I think since we need Module::CPANfile in os-autoinst as well in the future to be able to run tools/tidyall, we need it to add there as a dependency anyway. Preparing that now... |
Waiting for: |
149ace9
to
8eed188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the git commit message I suggest that the subject line states the "Why", not the "What". How about
"Ensure to run the same perltidy versions as downstream projects"
And in the details you can still say
"By using our os-autoinst_dev container for running perltidy same as in e.g. os-autoinst or openQA we are running the same perltidy version as in there. This fixes the problem that a new release of Perl::Tidy on CPAN would bring in a need to update to the new version whereas in downstream projects we are relying on the version that is in openSUSE Tumbleweed and Leap."
By using our os-autoinst_dev container for running perltidy same as in e.g. os-autoinst or openQA we are running the same perltidy version as in there. This fixes the problem that a new release of Perl::Tidy on CPAN would bring in a need to update to the new version whereas in downstream projects we are relying on the version that is in openSUSE Tumbleweed and Leap.
8eed188
to
a741e48
Compare
By using our os-autoinst_dev container for running perltidy same as in e.g.
os-autoinst or openQA we are running the same perltidy version as in there.
This fixes the problem that a new release of Perl::Tidy on CPAN would bring in
a need to update to the new version whereas in downstream projects we are
relying on the version that is in openSUSE Tumbleweed and Leap.