Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix sync issue in setup_multimachine leading to sporadic failures" #18757

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

michaelgrifalconi
Copy link
Contributor

Reverts #18754

Most if not all multimachine tests are broken today. Might be due to this PR

@michaelgrifalconi
Copy link
Contributor Author

Well, would be nice to have "commit message check" to ignore length on revert commits

@okurz okurz merged commit 5fa5fae into master Feb 28, 2024
12 of 14 checks passed
@okurz okurz deleted the revert-18754-mm-sync branch February 28, 2024 07:24
@michaelgrifalconi
Copy link
Contributor Author

Thanks for the quick merge Oliver :) was just about to push the amended commit message

@okurz
Copy link
Member

okurz commented Feb 28, 2024

@michaelgrifalconi it's fine. If you are interested to look into the commit message check: That is using https://github.com/marketplace/actions/gs-commit-message-checker which has the possibility to check for certain things with regex. Maybe you have an idea what could be configured to exclude commit messages where the subject line starts with "Revert"

@michaelgrifalconi
Copy link
Contributor Author

@okurz proposed os-autoinst/os-autoinst-common#51 :)

@Martchus
Copy link
Contributor

Martchus commented Feb 28, 2024

Most if not all multimachine tests are broken today. Might be due to this PR

What tests are you talking about specifically?

EDIT: I found one: https://openqa.suse.de/tests/13623166 (via https://openqa.suse.de/tests/overview?modules=setup_multimachine and going though Next & Previous)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants